Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also compare across forks.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also compare across forks.
...
  • 2 commits
  • 1 file changed
  • 0 commit comments
  • 2 contributors
Commits on Jan 13, 2014
@chilvence chilvence IncrementGlobalOnce: Increase both variables, not just the second
 -fixes DUHIR.DLG uhir's lucky knife quest and hopefully many others
188e980
@lynxlynxlynx lynxlynxlynx Merge pull request #15 from chilvence/fixesonly
IncrementGlobalOnce: Increase both variables, not just the second
f35d055
Showing with 6 additions and 0 deletions.
  1. +6 −0 gemrb/core/GameScript/Actions.cpp
View
6 gemrb/core/GameScript/Actions.cpp
@@ -3308,6 +3308,12 @@ void GameScript::IncrementGlobalOnce(Scriptable* Sender, Action* parameters)
if (value != 0) {
return;
}
+ //todo:the actual behaviour of this opcode may need to be verified, as this is
+ //just a best guess at how the two parameters are changed, and could
+ //well be more complex; the original usage of this function is currently
+ //not well understood (relates to hardcoded alignment changes)
+ SetVariable( Sender, parameters->string0Parameter, parameters->int0Parameter );
+
value = CheckVariable( Sender, parameters->string1Parameter );
SetVariable( Sender, parameters->string1Parameter,
value + parameters->int0Parameter );

No commit comments for this range

Something went wrong with that request. Please try again.