New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "--format" with the log method now throws a Git::Wrapper::Exception #65

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@estrabd

estrabd commented Mar 23, 2015

Issue 43: Updated Git::Wrapper::log to throw an exception if "--format" is
detected as a passed-in option. A unit test was added to make sure the
exception was thrown in the right case. The POD was updated to underscore
the fact that the log method shall die if "--format" is detected and points
reader to the documentation on the RUN method, which now includes an example
of calling 'log' directly with the '--format' option.

B. Estrade
Using "--format" with the log method now throws a Git::Wrapper::Excep…
…tion.

Issue 43: Updated Git::Wrapper::log to throw an exception if "--format" is
detected as a passed-in option. A unit test was added to make sure the
exception was thrown in the right case. The POD was updated to underscore
the fact that the log method shall die if "--format" is detected and points
reader to the documentation on the RUN method, which now includes an example
of calling 'log' directly with the '--format' option.

@estrabd estrabd referenced this pull request Mar 23, 2015

Closed

git log --format #43

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Mar 23, 2015

Coverage Status

Coverage increased (+0.13%) to 84.98% when pulling dfd17a4 on estrabd:Issue-43-throw-exception-on-log-format into 92c2d10 on genehack:master.

coveralls commented Mar 23, 2015

Coverage Status

Coverage increased (+0.13%) to 84.98% when pulling dfd17a4 on estrabd:Issue-43-throw-exception-on-log-format into 92c2d10 on genehack:master.

@genehack

This comment has been minimized.

Show comment
Hide comment
@genehack

genehack Mar 24, 2015

Owner

I merged a (very slightly tweaked) version of this, and put out a trial release. I'm going to be AFK a bunch this coming week, but if the tests look okay by Saturday or so, I'll move the trial to a regular release.

Thanks for doing this!

Owner

genehack commented Mar 24, 2015

I merged a (very slightly tweaked) version of this, and put out a trial release. I'm going to be AFK a bunch this coming week, but if the tests look okay by Saturday or so, I'll move the trial to a regular release.

Thanks for doing this!

@genehack genehack closed this Mar 24, 2015

@estrabd

This comment has been minimized.

Show comment
Hide comment
@estrabd

estrabd Mar 24, 2015

You're welcome.

estrabd commented Mar 24, 2015

You're welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment