New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for test 'Unfound path in constructor error message' #4

Merged
merged 1 commit into from Mar 13, 2015

Conversation

Projects
None yet
2 participants
@openstrike
Contributor

openstrike commented Mar 2, 2015

Some of the cpantesters results show that this test fails for non-English locales. The test originally checked for the error response in $! which comes from the O/S and which may be in the language of the user - see eg. http://www.cpantesters.org/cpan/report/c77e9d30-c0a4-11e4-99c5-a688e0bfc7aa
I apologise that my original version did not pick up this possibility.

To mitigate this, the test now looks at the perl-generated part of the error message and tries to match against that instead. I've tested this with a non-English locale (fr_FR) and the test passes.

Bug fix for test 'Unfound path in constructor error message'
Test now checks for perl message rather than varying O/S message.

genehack added a commit that referenced this pull request Mar 13, 2015

Merge pull request #4 from openstrike/coverage
Bug fix for test 'Unfound path in constructor error message'

@genehack genehack merged commit afefce1 into genehack:master Mar 13, 2015

@genehack

This comment has been minimized.

Owner

genehack commented Mar 13, 2015

Thanks!

genehack added a commit that referenced this pull request Mar 13, 2015

Merge pull request #4 from openstrike/coverage
Bug fix for test 'Unfound path in constructor error message'

@openstrike openstrike deleted the openstrike:coverage branch Mar 14, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment