Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Autocompleter free values20 #66

Closed
wants to merge 113 commits into
from

Conversation

Projects
None yet
Contributor

PoisonousJohn commented Mar 12, 2012

same things for 2.0 branch

referenced PR #64

genemu and others added some commits Nov 24, 2011

Merge pull request #13 from Seldaek/patch-1
Fix composer.json syntax
Merge pull request #14 from Pentium133/2.0
fix error on create service because parameter is passed as a string
Merge pull request #15 from Pentium133/2.0
fix parameter name for tiny_mce configs
Merge pull request #16 from Spea/2.0
Fixed namespace typo
Merge pull request #23 from Schyzophrenic/2.0
2.0: Fixing the image MIME Type test in the constructor
change genemu_jquerychosen_widget so that the standard 'chzn-select' …
…class attribute value is added to an existing class attribute (if it exists), rather than overwriting it.
make it possible to set the value for 'data-placeholder' text to some…
…thing different than the text defined by the 'empty_value' option, this is done setting the 'attr' property 'placeholder'. the value of the 'empty_value' property is used if 'placeholder' is not set.
Merge pull request #28 from hoppinger/chosen_autocomplete
Jquery-Chosen with ajax autocomplete

Adam Kusmierz and others added some commits Feb 28, 2012

A Form type that just renders the field as a p tag. This is useful fo…
…r forms where certain field need to be shown but not editable.

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Fix formatting for PlainType
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
New Form Type - TokenInput (http://loopj.com/jquery-tokeninput/).
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Now you can use tokeninput in the same way as autocompleter
You have to apply the fix https://github.com/loopj/jquery-tokeninput/pull/172/files for tokeninput to get it work!

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Added comment
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Kind of validation in ChoiceToJsonTransformer and changed some defaul…
…t options for token input (now should work)

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Now edit works correct
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Now it works also for multiple = false
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Merge pull request #57 from kusmierz/2.0
Now it works also for multiple = false
Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax query.
Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax query.
Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax request.
Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax request.
Merge pull request #68 from sterrien/2.0
2.0 - new parameter for ajax autocompleter
Merge pull request #71 from sterrien/2.0
2.0 Jquery autocomplete entity (rollback)
Contributor

Schyzophrenic commented Mar 20, 2012

I hope this will be merged in 2.0 soon. Thanks for the fix

+1 would love to see this pull request merged in 2.0 branch. Thanks.

kkrasnik commented Apr 4, 2012

+1 would love to see this pull request merged in 2.0 branch. Thanks.

Contributor

PoisonousJohn commented May 12, 2012

@genemu updated according to your latest 2.0 commits

chrux and others added some commits May 21, 2012

Solving problem with annotations -Unterminated comment starting line …
…9 in /Users/christian/Developer/php/regalon/vendor/doctrine-common/lib/Doctrine/Common/Annotations/PhpParser.php on line 64-
Collaborator

bamarni commented Jun 3, 2012

@johnpoison: could you rebase it?

Contributor

PoisonousJohn commented Jun 19, 2012

@bamarni did rebase and added "staticList" option that allows autocompleter query server for a full list once

could you use 'static_list'? to be compliant with the other options.

Collaborator

bamarni commented Jun 19, 2012

@johnpoison: I still can't merge it, don't know exactly what happened but it looks like your banch diverged at some point, we shouldn't see this long commit list.

Contributor

PoisonousJohn commented Jun 19, 2012

@bamarni ok i'll change it to static_list and free_values. And will try to do something with commits problem

Contributor

Schyzophrenic commented Jul 20, 2012

Any news for this? I would really love to have this problem solved!

Collaborator

bamarni commented Aug 16, 2012

@johnpoison : the issue is that you did your pull request against matser instead of 2.0, that's why the history diverges.

Personally I don't like the behavior of our autocompleter, it is not natural, we're rendering a text box so of course the user is expecting free values, but it's not the case. And the free_values option we added doesn't really make sense because the value added manually with the keyboard are supposed to be labels, but we're mixing them with the other ones, wich are not labels but values.

IMO an autocompleter should only suggest things, and don't act as a choice list, that's why I've added this one :
https://github.com/genemu/GenemuFormBundle/blob/master/Resources/doc/jquery/autocomplete/text.md

I'm thinking about removing the choice autocompleter for a later branch of the bundle, and only keep the one with suggestions (but of course adding to it some features like doctrine, ... but without this double value / label thing).

Does anyone have objection about it?

Contributor

PoisonousJohn commented Aug 16, 2012

@bamarni I agree. This is a good solution

Contributor

Schyzophrenic commented Aug 16, 2012

@bamarni This is indeed very confusing. I remember having a hard time the first time I used it. Your modifications make sense imo.

Collaborator

bamarni commented Aug 16, 2012

ok great, I'm opening an issue not to forget :)

@bamarni bamarni closed this Aug 16, 2012

Contributor

Schyzophrenic commented Aug 16, 2012

Thanks ! Will this be ported to 2.0 as well?
Le 16 août 2012 14:15, "Bilal Amarni" notifications@github.com a écrit :

ok great, I'm opening an issue not to forget :)


Reply to this email directly or view it on GitHubhttps://github.com/genemu/GenemuFormBundle/pull/66#issuecomment-7783671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment