Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Autocompleter free values20 #66

Closed
wants to merge 113 commits into from
@JohnPoison

same things for 2.0 branch

referenced PR #64

and others added some commits
@genemu Fixed Branch 2.0 33de0c4
@genemu Fixed travis-ci 9c19abf
@genemu Fixed AjaxDocumentType 1892f26
@genemu Fixed2 AjaxDocumentType cb88766
@genemu Fixed AjaxEntityType f526d5d
@genemu Fixed value return to Autocompleter 9e30ad2
@genemu Fixed JSON to JQuery 7aa9cee
@genemu Fixed reverseTransform JSON caf3b50
@genemu Add test travis-ci from multiple version to Symfony 27bd816
@genemu Remove old file JQueryAutocompleterType 6bb7f94
@genemu Fixed mongodb to doctrine e9afef2
@genemu Add posibility to doctrine false from JQueryAutocompleter 3684c19
@genemu Refactoring code de07c46
@genemu Remove var_dump :o) 947177d
@genemu Fixed defaultOptions date a99ac44
@genemu Fixed link doc adb61dc
@genemu Fixed link doc captcha gd c65aa7a
@genemu Typo composer.json 921b40e
@Seldaek Seldaek Fix JSON syntax 13795a9
@genemu Merge pull request #13 from Seldaek/patch-1
Fix composer.json syntax
715c64b
@genemu Add vendor propel tests 49b72f4
@genemu Fixed Recaptcha to event handler 248c338
@Pentium133 Pentium133 fix error on create service when parameter is passed as a string a220f16
@genemu Merge pull request #14 from Pentium133/2.0
fix error on create service because parameter is passed as a string
9016acd
@genemu Add Color filed and Rating field 1703193
@genemu Update doc 7cbc517
@genemu Fixed doc rating 68d48c0
@Pentium133 Pentium133 fix parameter name for tiyu_mce configs ef932f5
@genemu Merge pull request #15 from Pentium133/2.0
fix parameter name for tiny_mce configs
170459b
@Spea Spea Fixed namespace typo. 5831ea7
@genemu Merge pull request #16 from Spea/2.0
Fixed namespace typo
39a01e4
@genemu merge master 925a52b
@genemu Update README 916d665
@genemu Refactoring code and Fixed CaptchaGD to IE6 and IE7 7330656
@genemu Removed test code c18c180
@genemu Fixed configuration 6279e91
@genemu Fixed2 e55668b
@genemu Fixed3 791592d
@genemu Fixed jquery.xml ac9e96d
@genemu fixed recpatcha 681cbab
@Schyzophrenic Schyzophrenic Fixing the Image MIME Type test 27f4c4a
@genemu Merge pull request #23 from Schyzophrenic/2.0
2.0: Fixing the image MIME Type test in the constructor
f818add
@genemu Fixed test d40c052
@genemu Fixed autocompleter to doctrine entity for Symfony 2.0.8 b946502
@genemu Possible date format for config type to jquerydatetype 47b6d31
@genemu Fixed by Schyzophrenic b6470b1
@genemu Fixed jqueryimage c02184b
@genemu Fixed recaptcha and add multiple eventListener for all browser c01d99c
@iamjochem iamjochem change genemu_jquerychosen_widget so that the standard 'chzn-select' …
…class attribute value is added to an existing class attribute (if it exists), rather than overwriting it.
c3057af
@iamjochem iamjochem make it possible to set the value for 'data-placeholder' text to some…
…thing different than the text defined by the 'empty_value' option, this is done setting the 'attr' property 'placeholder'. the value of the 'empty_value' property is used if 'placeholder' is not set.
bae536c
@iamjochem iamjochem rudimentary implementation of AJAX-based auto-completion for the jque…
…ry_chosen formtype.
b28a5ec
@genemu Merge pull request #28 from hoppinger/chosen_autocomplete
Jquery-Chosen with ajax autocomplete
ea2111f
@butt butt added option 'disable_guess_extension' e9ac7ba
@butt butt [*] update documentation 5094c69
@butt butt added check for upload php file 024f905
@genemu Merge pull request #29 from butt/2.0
Bugfix
8cd83b6
@butt butt I changed $value and set original file path 73e6354
@butt butt added option 'custom_storage_folder' 2e1493f
@butt butt 'custom_storage_folder' be95c1c
@genemu Merge pull request #31 from butt/2.0 444846e
@butt butt set original image path for replaced file e8c0a22
@genemu Merge pull request #34 from butt/2.0
it is addition for my latest pull request (#31)
c3b2c70
@butt butt added check $data 223f89e
@genemu Merge pull request #36 from butt/2.0
fixed incorect file path when file pointed to the folder different from $configs['folder']
343038a
@butt butt Fixed 'Warning: Unterminated comment starting line 11 in Z:\apache\Vi…
…do.com.ua\vendor\doctrine-common\lib\Doctrine\Common\Annotations\PhpParser.php on line 64'
5e2a7a2
@genemu Merge pull request #42 from butt/2.0
Fixed PhpParser Warning like master branch
ded860f
@geecu geecu fix notice when the listener is added twice 284c473
Adam Kusmierz Allowing nonDocumentRoot location of app
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
dcef057
@geecu geecu setting a config script would not work 5339a29
@genemu Merge pull request #48 from geecu/fix_file_config
Fix file config
e7f32bc
Adam Kusmierz Merge branch '2.0' of git://github.com/genemu/GenemuFormBundle into 2.0 4714edd
Adam Kusmierz A Form type that just renders the field as a p tag. This is useful fo…
…r forms where certain field need to be shown but not editable.

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
910e8a3
Adam Kusmierz Fix formatting for PlainType
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
ea0d683
Adam Kusmierz New Form Type - TokenInput (http://loopj.com/jquery-tokeninput/).
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
64aa959
Adam Kusmierz Now you can use tokeninput in the same way as autocompleter
You have to apply the fix https://github.com/loopj/jquery-tokeninput/pull/172/files for tokeninput to get it work!

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
33e9d08
Adam Kusmierz Configuration for tokeninput and removed one debug line from jquery_l…
…ayout.
93de63c
Adam Kusmierz Added comment
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
e52ae88
@genemu Merge pull request #52 from kusmierz/2.0
Sync with 2.0 branch
97fa633
Adam Kusmierz Kind of validation in ChoiceToJsonTransformer and changed some defaul…
…t options for token input (now should work)

Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
f231614
Adam Kusmierz Now edit works correct
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
35622fd
@genemu Merge pull request #55 from kusmierz/2.0
Fix tokeninput @2.0
83284a9
Adam Kusmierz Now it works also for multiple = false
Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
0accaa1
Adam Kusmierz Merge remote-tracking branch 'upstream/2.0' into 2.0 41125a4
@genemu Merge pull request #57 from kusmierz/2.0
Now it works also for multiple = false
1a08071
@sterrien sterrien choices can not be null, it must be an array or \Closure 3b4342a
@sterrien sterrien choices can not be null, it must be an array or \Closure c932237
@sterrien sterrien Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax query.
3f2e9e0
@sterrien sterrien Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax query.
6161610
@sterrien sterrien Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax request.
d9a4e2a
@sterrien sterrien Adding an option named 'ids', containing an array of input ids.
The values of these input will be passed into the ajax request.
b750c65
@genemu Merge pull request #68 from sterrien/2.0
2.0 - new parameter for ajax autocompleter
b8eed2c
@Schyzophrenic Schyzophrenic Allow the use of the JQueryFile Field within a form collection b030e56
@Schyzophrenic Schyzophrenic Allow the use of the JQueryFile Field within a form collection 3eba8b1
@Schyzophrenic Schyzophrenic Allow the use of the JQueryFile Field within a form collection 4191698
@Schyzophrenic Schyzophrenic Fix the doctrine entity autocompleter field. (Revert the changes from…
… PR #68, which brought the regression).
8f733e7
@Schyzophrenic Schyzophrenic Allow chosen field to be called within a form collection 781bd18
@Schyzophrenic Schyzophrenic Allow chosen field to be called within a form collection e19413f
@Schyzophrenic Schyzophrenic Allow chosen field to be called within a form collection 4d2aea9
@Schyzophrenic Schyzophrenic Allow chosen field to be called within a form collection 4e25909
@sterrien sterrien rollback : choices can't be null in Symfony 2.0.4. But now, it can. 447e371
@sterrien sterrien rollback : choices can't be null in Symfony 2.0.4. But now, it can. b2eca5e
@sterrien sterrien Update Form/Doctrine/ChoiceList/AjaxEntityChoiceList.php 85adf0d
@genemu Merge pull request #71 from sterrien/2.0
2.0 Jquery autocomplete entity (rollback)
2360300
@Schyzophrenic

I hope this will be merged in 2.0 soon. Thanks for the fix

@keymaster

+1 would love to see this pull request merged in 2.0 branch. Thanks.

@kkrasnik

+1 would love to see this pull request merged in 2.0 branch. Thanks.

@JohnPoison

@genemu updated according to your latest 2.0 commits

chrux and others added some commits
@chrux chrux Solving problem with annotations -Unterminated comment starting line …
…9 in /Users/christian/Developer/php/regalon/vendor/doctrine-common/lib/Doctrine/Common/Annotations/PhpParser.php on line 64-
13d7a50
@bamarni bamarni Merge pull request #92 from chrux/2.0
2.0
2e9cdb8
@bamarni
Collaborator

@JohnPoison: could you rebase it?

@JohnPoison

@bamarni did rebase and added "staticList" option that allows autocompleter query server for a full list once

@bamarni

could you use 'static_list'? to be compliant with the other options.

@bamarni
Collaborator

@JohnPoison: I still can't merge it, don't know exactly what happened but it looks like your banch diverged at some point, we shouldn't see this long commit list.

@JohnPoison

@bamarni ok i'll change it to static_list and free_values. And will try to do something with commits problem

@Schyzophrenic

Any news for this? I would really love to have this problem solved!

@bamarni
Collaborator

@JohnPoison : the issue is that you did your pull request against matser instead of 2.0, that's why the history diverges.

Personally I don't like the behavior of our autocompleter, it is not natural, we're rendering a text box so of course the user is expecting free values, but it's not the case. And the free_values option we added doesn't really make sense because the value added manually with the keyboard are supposed to be labels, but we're mixing them with the other ones, wich are not labels but values.

IMO an autocompleter should only suggest things, and don't act as a choice list, that's why I've added this one :
https://github.com/genemu/GenemuFormBundle/blob/master/Resources/doc/jquery/autocomplete/text.md

I'm thinking about removing the choice autocompleter for a later branch of the bundle, and only keep the one with suggestions (but of course adding to it some features like doctrine, ... but without this double value / label thing).

Does anyone have objection about it?

@JohnPoison

@bamarni I agree. This is a good solution

@Schyzophrenic

@bamarni This is indeed very confusing. I remember having a hard time the first time I used it. Your modifications make sense imo.

@bamarni
Collaborator

ok great, I'm opening an issue not to forget :)

@bamarni bamarni closed this
@Schyzophrenic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Nov 24, 2011
  1. Fixed Branch 2.0

    authored
  2. Fixed travis-ci

    authored
  3. Fixed AjaxDocumentType

    authored
  4. Fixed2 AjaxDocumentType

    authored
  5. Fixed AjaxEntityType

    authored
  6. Fixed JSON to JQuery

    authored
  7. Fixed reverseTransform JSON

    authored
  8. Fixed mongodb to doctrine

    authored
Commits on Nov 26, 2011
  1. Refactoring code

    authored
  2. Remove var_dump :o)

    authored
  3. Fixed defaultOptions date

    authored
  4. Fixed link doc

    authored
  5. Fixed link doc captcha gd

    authored
  6. Typo composer.json

    authored
  7. @Seldaek

    Fix JSON syntax

    Seldaek authored
  8. Merge pull request #13 from Seldaek/patch-1

    authored
    Fix composer.json syntax
Commits on Nov 27, 2011
  1. Add vendor propel tests

    authored
Commits on Nov 28, 2011
Commits on Nov 29, 2011
  1. @Pentium133
  2. Merge pull request #14 from Pentium133/2.0

    authored
    fix error on create service because parameter is passed as a string
  3. Update doc

    authored
  4. Fixed doc rating

    authored
Commits on Nov 30, 2011
  1. @Pentium133
  2. Merge pull request #15 from Pentium133/2.0

    authored
    fix parameter name for tiny_mce configs
  3. @Spea

    Fixed namespace typo.

    Spea authored
  4. Merge pull request #16 from Spea/2.0

    authored
    Fixed namespace typo
Commits on Dec 2, 2011
  1. merge master

    authored
  2. Update README

    authored
Commits on Dec 15, 2011
  1. Removed test code

    authored
  2. Fixed configuration

    authored
  3. Fixed2

    authored
  4. Fixed3

    authored
Commits on Dec 16, 2011
  1. Fixed jquery.xml

    authored
Commits on Dec 26, 2011
  1. fixed recpatcha

    authored
Commits on Jan 4, 2012
  1. @Schyzophrenic
  2. Merge pull request #23 from Schyzophrenic/2.0

    authored
    2.0: Fixing the image MIME Type test in the constructor
  3. Fixed test

    authored
Commits on Jan 5, 2012
  1. Fixed by Schyzophrenic

    authored
Commits on Jan 6, 2012
  1. Fixed jqueryimage

    authored
Commits on Jan 25, 2012
  1. @iamjochem

    change genemu_jquerychosen_widget so that the standard 'chzn-select' …

    iamjochem authored
    …class attribute value is added to an existing class attribute (if it exists), rather than overwriting it.
  2. @iamjochem

    make it possible to set the value for 'data-placeholder' text to some…

    iamjochem authored
    …thing different than the text defined by the 'empty_value' option, this is done setting the 'attr' property 'placeholder'. the value of the 'empty_value' property is used if 'placeholder' is not set.
  3. @iamjochem
Commits on Jan 26, 2012
  1. Merge pull request #28 from hoppinger/chosen_autocomplete

    authored
    Jquery-Chosen with ajax autocomplete
Commits on Feb 3, 2012
  1. @butt
  2. @butt

    [*] update documentation

    butt authored
  3. @butt

    added check for upload php file

    butt authored
  4. Merge pull request #29 from butt/2.0

    authored
    Bugfix
Commits on Feb 7, 2012
  1. @butt
  2. @butt
  3. @butt

    'custom_storage_folder'

    butt authored
Commits on Feb 14, 2012
  1. @butt
  2. Merge pull request #34 from butt/2.0

    authored
    it is addition for my latest pull request (#31)
Commits on Feb 16, 2012
  1. @butt

    added check $data

    butt authored
  2. Merge pull request #36 from butt/2.0

    authored
    fixed incorect file path when file pointed to the folder different from $configs['folder']
Commits on Feb 21, 2012
  1. @butt

    Fixed 'Warning: Unterminated comment starting line 11 in Z:\apache\Vi…

    butt authored
    …do.com.ua\vendor\doctrine-common\lib\Doctrine\Common\Annotations\PhpParser.php on line 64'
  2. Merge pull request #42 from butt/2.0

    authored
    Fixed PhpParser Warning like master branch
Commits on Feb 27, 2012
  1. @geecu
  2. Allowing nonDocumentRoot location of app

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Commits on Feb 28, 2012
  1. @geecu
  2. Merge pull request #48 from geecu/fix_file_config

    authored
    Fix file config
  3. A Form type that just renders the field as a p tag. This is useful fo…

    Adam Kusmierz authored
    …r forms where certain field need to be shown but not editable.
    
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
Commits on Feb 29, 2012
  1. Fix formatting for PlainType

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  2. New Form Type - TokenInput (http://loopj.com/jquery-tokeninput/).

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  3. Now you can use tokeninput in the same way as autocompleter

    Adam Kusmierz authored
    You have to apply the fix https://github.com/loopj/jquery-tokeninput/pull/172/files for tokeninput to get it work!
    
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  4. Added comment

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  5. Merge pull request #52 from kusmierz/2.0

    authored
    Sync with 2.0 branch
Commits on Mar 2, 2012
  1. Kind of validation in ChoiceToJsonTransformer and changed some defaul…

    Adam Kusmierz authored
    …t options for token input (now should work)
    
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  2. Now edit works correct

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  3. Merge pull request #55 from kusmierz/2.0

    authored
    Fix tokeninput @2.0
  4. Now it works also for multiple = false

    Adam Kusmierz authored
    Signed-off-by: Adam Kusmierz <kusmierz@gmail.com>
  5. Merge remote-tracking branch 'upstream/2.0' into 2.0

    Adam Kusmierz authored
Commits on Mar 3, 2012
  1. Merge pull request #57 from kusmierz/2.0

    authored
    Now it works also for multiple = false
Commits on Mar 15, 2012
  1. @sterrien
  2. @sterrien
  3. @sterrien

    Adding an option named 'ids', containing an array of input ids.

    sterrien authored
    The values of these input will be passed into the ajax query.
  4. @sterrien

    Adding an option named 'ids', containing an array of input ids.

    sterrien authored
    The values of these input will be passed into the ajax query.
Commits on Mar 16, 2012
  1. @sterrien

    Adding an option named 'ids', containing an array of input ids.

    sterrien authored
    The values of these input will be passed into the ajax request.
  2. @sterrien

    Adding an option named 'ids', containing an array of input ids.

    sterrien authored
    The values of these input will be passed into the ajax request.
  3. Merge pull request #68 from sterrien/2.0

    authored
    2.0 - new parameter for ajax autocompleter
Commits on Mar 17, 2012
  1. @Schyzophrenic
  2. @Schyzophrenic
  3. @Schyzophrenic
Commits on Mar 18, 2012
  1. @Schyzophrenic

    Fix the doctrine entity autocompleter field. (Revert the changes from…

    Schyzophrenic authored
    … PR #68, which brought the regression).
Commits on Mar 19, 2012
  1. @Schyzophrenic
  2. @Schyzophrenic
  3. @Schyzophrenic
  4. @Schyzophrenic
  5. @sterrien
  6. @sterrien
  7. @sterrien
  8. Merge pull request #71 from sterrien/2.0

    authored
    2.0 Jquery autocomplete entity (rollback)
Commits on Apr 18, 2012
  1. @pierroweb
  2. Merge pull request #84 from pierroweb/widget-timezone-2.0

    authored
    add timezone widget for 2.0 branch as well
Commits on May 21, 2012
  1. @chrux

    Solving problem with annotations -Unterminated comment starting line …

    chrux authored
    …9 in /Users/christian/Developer/php/regalon/vendor/doctrine-common/lib/Doctrine/Common/Annotations/PhpParser.php on line 64-
Commits on Jun 3, 2012
  1. @bamarni

    Merge pull request #92 from chrux/2.0

    bamarni authored
    2.0
  2. @bamarni

    fixed #65

    bamarni authored
Commits on Jun 13, 2012
  1. @bamarni

    Merge pull request #70 from Schyzophrenic/2.0

    bamarni authored
    Allow the use of the JQueryFile and Chosen field elements within a form Collection
Commits on Jun 14, 2012
  1. @damienalexandre
  2. @bamarni

    Merge pull request #107 from damienalexandre/patch-1

    bamarni authored
    Try to have the culture closer from the jQuery i18n bad culture formats
Commits on Jun 19, 2012
  1. @JohnPoison

    actual statue

    JohnPoison authored
  2. @JohnPoison
Something went wrong with that request. Please try again.