Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fungal NTRs: Perithecium development & Protoperithecium formation #15616

Closed
Achchuthan opened this issue Apr 19, 2018 · 6 comments
Closed

Fungal NTRs: Perithecium development & Protoperithecium formation #15616

Achchuthan opened this issue Apr 19, 2018 · 6 comments
Assignees

Comments

@Achchuthan
Copy link

Achchuthan commented Apr 19, 2018

Accession: GO:xxxxxx
Name: Perithecium development
Ontology: biological_process
Definition: The process whose specific outcome is the progression of a perithecium over time, from its formation to the mature structure. Peritheicum is a flask-shaped fruiting body of certain molds and ascomycetous fungi having a pore for the escape of spores. In the ascomycetous fungi such as Neurospora crassa and Sordaria macrospora, these perithecia are formed in the sexual phase and they discharge ascospores through the ostiolum at the tip of the perithecial neck.
is_a: GO:0030582 ! reproductive fruiting body development
Source: BTO:0002164, PMID:125266, PMID:19547974, PMID:20739093, PMID:25311923, https://link.springer.com/chapter/10.1007/978-3-642-00286-1_2

Accession: GO:xxxxxx
Name: Protoperithecium formation
Ontology: biological_process
Synonyms: Primordium formation
Definition: The process of producing fruiting body precursors, called protoperithecia. Protoperitheicium is a spherical structure that is formed in the sexual phase of ascomycetous fungi such as Neurospora crassa and Sordaria macrospora. Protoperithecium is formed by the enveloping of ascogonia cells by sterile hyphae and it develops into perithecium.
Comment: Note that this term represents protoperithecium formation across homothallic and heterothallic species that do not have the same mechanism.
is_a: GO:0030582 ! reproductive fruiting body development
Source: PMID:125266, PMID:4410944, PMID:6235211, PMID:6235212, PMID:20739093, PMID:25311923, https://link.springer.com/chapter/10.1007/978-3-642-00286-1_2

@Achchuthan Achchuthan changed the title NTRs: Perithecium development & Protoperithecium formation Fungal NTRs: Perithecium development & Protoperithecium formation Apr 23, 2018
@krchristie
Copy link
Contributor

I have temporarily removed definition dbxrefs that were from BTO or were urls as they are violating a check for valid IDs in references:

:: ERROR: valid-id-space: bad id space 'BTO' in xref BTO:0002164
:: ERROR: valid-id-space: bad id space 'https' in xref https://link.springer.com/chapter/10.1007

@Achchuthan - Are these urls for DOI's? If so, then the appropriate format is like this:

DOI:10.1078/0176-1617-00593

@cmungall - What is needed to allow a BTO ID as a definition dbxref? BTO is a valid OBO Foundry ontology. Here's the link for the relevent BTO term:
http://www.ontobee.org/ontology/BTO?iri=http://purl.obolibrary.org/obo/BTO_0002164

@krchristie krchristie assigned cmungall and krchristie and unassigned krchristie May 17, 2018
krchristie added a commit that referenced this issue May 17, 2018
…eciumRelated-15617-15616

3 new terms for fungi, fixes #15617 fixes #15616
@krchristie
Copy link
Contributor

reopening until BTO issue is resolved

@krchristie krchristie reopened this May 17, 2018
krchristie added a commit to krchristie/go-site that referenced this issue May 22, 2018
I need to be able to refer to a term from the Brenda tissue / enzyme source for a term I added based on this request:
geneontology/go-ontology#15616
@krchristie
Copy link
Contributor

@cmungall - There's a pull request to add an entry for BTO to db-xrefs.yaml:
geneontology/go-site#655

I'm not sure why it failed, or why I never saw an option to add you as a reviewer.

@krchristie
Copy link
Contributor

Tried again (#15842) to put in BTO reference:

but still getting this error:
:: ERROR: valid-id-space: bad id space 'BTO' in xref BTO:0002164

@cmungall
Copy link
Member

cmungall commented Jun 1, 2018

sorry I missed this the first time round. Merged, but will take a day to percolate.

I propose as a general principle for development terms

  • we axiomatize using the appropriate ontology (FAO here)
  • we don't reference an ontology term in the development term def xref as this is redundant (but FAO may choose to reference a BTO term if it chooses)

@cmungall
Copy link
Member

cmungall commented Jun 1, 2018

FAO request: obophenotype/fungal-anatomy-ontology#19
Inquiry into status of FAO: obophenotype/fungal-anatomy-ontology#18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants