Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GPAD specifications #674

Closed
pgaudet opened this issue Jun 6, 2018 · 9 comments
Closed

Update GPAD specifications #674

pgaudet opened this issue Jun 6, 2018 · 9 comments

Comments

@pgaudet
Copy link
Contributor

pgaudet commented Jun 6, 2018

Update GPAD specifications to use identifiers for relations in place of term labels. This would hold for the Qualifier column as well as Annotation Extensions.
Proposal wrt GAF and GPAD: keep both; increment in sync. Issues to consider: relations, evidence codes

@tonysawfordebi
Copy link
Contributor

I thought that the decision was taken to freeze GAF as it is now, and only to update GPAD?

@pgaudet
Copy link
Contributor Author

pgaudet commented Jun 6, 2018

humm could be - but I thought this was a problem for people consuming GAF. I just copied what's in the GOC minutes. I'll add this to the managers discussion for clarification. Thanks for pointing that out!

@ukemi
Copy link
Contributor

ukemi commented Jun 6, 2018

We also need to keep in mind that if this happens, it is a new format for GPAD that is different from the existing specs. Therefore it can't just happen without advanced notice.

@tonysawfordebi
Copy link
Contributor

Indeed, @ukemi, and it would be a non-trivial amount of work on our side too, but I think that it's the right thing to do.

@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 6, 2018

@pgaudet
Copy link
Contributor Author

pgaudet commented Nov 6, 2018

Suggest from @tonysawfordebi from the Montreal 10-2018 GOC meeting:
Extend GPAD header (any annotation set generated by any group) to include PURL for GO ontology information (or snapshot/release DOI), (last ‘good’) version of the ontology that was in use when annotations were made

@tonysawfordebi
Copy link
Contributor

Executive summary of the main changes proposed at the Montreal meeting (or, at least, the ones that I remember):

  • bump version to 2.0
  • extend header to include GO version URI (as mentioned in Update GPAD specifications #674 (comment))
  • merge columns 1 and 2 (db and db_object_id) so that objects are always referred to by a CURIE everywhere
  • replace relation labels with RO IDs wherever they are used
  • demerge the qualifier column into two: gp-to-GO-term relation and an is-negated (NOT) flag
  • identify a set of common properties and define the corresponding property names and value formats

@kltm
Copy link
Member

kltm commented Nov 6, 2018

I have some questions around the exact nature of "GO version URI":

Is this intended to be an optional use-if-there field, or something that is more important?

Right now, unless somebody creates their own URI and storage, GO currently only provides the possibility of versioned ontologies for "full" releases. Snapshot releases cannot currently be referenced permanently in any meaningful way, which puts up an immediate practical barrier (although there are obviously ways to engineer around that).

Also, what to do when there are multiple ontologies involved in a file/set? Unless part of the definition of the format it to lock it to one, if we are using GPAD as an interchange format, there will be a lot of cases where information from multiple upstreams that used different ontologies to be in one file.

@nathandunn nathandunn mentioned this issue May 7, 2019
73 tasks
@kltm kltm moved this from To do to In progress in GPAD/GPI 2.0 Specifications Sep 7, 2023
@kltm
Copy link
Member

kltm commented Sep 7, 2023

This ticket is the new spec, now finalized.

@kltm kltm closed this as completed Sep 7, 2023
@kltm kltm moved this from In progress to Done in GPAD/GPI 2.0 Specifications Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

No branches or pull requests

4 participants