New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bare CC annotation should generate part-of triples #10

Closed
cmungall opened this Issue Sep 20, 2017 · 2 comments

Comments

Projects
None yet
3 participants
@cmungall
Member

cmungall commented Sep 20, 2017

From: geneontology/noctua#492

Change the mapping from form to triples.

If BP and MF unspecified, and GP and CC are specified, then the generated triple should be:

gp type GP
cc type CC
gp part_of cc

also reverse

Note: this ONLY applies to the precise condition above, not any other condition

@cmungall

This comment has been minimized.

Show comment
Hide comment

cmungall added a commit that referenced this issue Sep 20, 2017

DO NOT MERGE: directly link GP-CC if no MF or BP
If no MF or BP, we assume a direct linkage from GP to CC, not mediated by a MF node.

Also: do not assume ND evidence is intended (see #10)

NOTE: I authored this quickly in the github web interface, not even sure if syntax is correct

NOTE: I only attempted the generative direction. The graph->form direction will also need handled.

Addresses #10

@kltm kltm added this to the hotfix milestone Sep 20, 2017

@tmushayahama tmushayahama modified the milestones: hotfix, 1.0 Nov 18, 2017

@cmungall cmungall changed the title from Bare MF annotation should generate part-of triples to Bare CC annotation should generate part-of triples Feb 8, 2018

@cmungall

This comment has been minimized.

Show comment
Hide comment
@cmungall

cmungall Feb 8, 2018

Member

Done in SAE

Member

cmungall commented Feb 8, 2018

Done in SAE

@cmungall cmungall closed this Feb 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment