Please explicitly build with -std=gnu89 (at least) so that compilation does not break when gcc/clang get more strict about enforcing C99 syntax

[sanjayankur31]

This is from the downstream Fedora bug here:

https://bugzilla.redhat.com/show_bug.cgi?id=2150772

From the change page:

https://fedoraproject.org/wiki/Changes/PortingToModernC

Back in 1999, a new revision of the C standard removed several backwards compatibility features. However, GCC still accepts these obsolete constructs by default. Support for these constructs is confusing to programmers and potentially affect GCC's ability to implement features from future C standards. It is expected that a future GCC version (likely GCC 14) will disable support for these legacy language constructs by default. The goal of this change is to prepare Fedora for this transition.

For the moment, we're adding -std=gnu89 to the Fedora build:

https://src.fedoraproject.org/rpms/genesis-simulator/c/f33cac2ccc71d1d77cdf6da58c333578616e98c7?branch=rawhide

[genesis-sim]

Hi Ankur, Thanks for continuing to include and maintain GENESIS in your Fedora Comp Neuro distribution. Although GENESIS is not often used in new modeling projects, there are several labs that continue to use GENESIS/PGENESIS in large scale network simulations. Your contributions and reports of issues on the github genesis-sim page are a big help to me and GENESIS users. Giving a link to your genesis.spec file was particularly helpful. I will make the change to Makefile.dist, test it, commit the changes, and close issue #6. I'll also alert the folks at the NSG portal, who have PGENESIS installed on their supercomputers. Thanks again for your help. Dave Beeman

…

________________________________ From: Ankur Sinha ***@***.***> Sent: Monday, December 5, 2022 4:57 AM To: genesis-sim/genesis-2.4 ***@***.***> Cc: Subscribed ***@***.***> Subject: [genesis-sim/genesis-2.4] Please explicitly build with -std=gnu89 (at least) so that compilation does not break when gcc/clang get more strict about enforcing C99 syntax (Issue #6) This is from the downstream Fedora bug here: https://bugzilla.redhat.com/show_bug.cgi?id=2150772 From the change page: https://fedoraproject.org/wiki/Changes/PortingToModernC Back in 1999, a new revision of the C standard removed several backwards compatibility features. However, GCC still accepts these obsolete constructs by default. Support for these constructs is confusing to programmers and potentially affect GCC's ability to implement features from future C standards. It is expected that a future GCC version (likely GCC 14) will disable support for these legacy language constructs by default. The goal of this change is to prepare Fedora for this transition. For the moment, we're adding -std=gnu89 to the Fedora build: https://src.fedoraproject.org/rpms/genesis-simulator/c/f33cac2ccc71d1d77cdf6da58c333578616e98c7?branch=rawhide — Reply to this email directly, view it on GitHub<#6>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACM52PPB2IO3WJJHDCDCAKLWLXKDXANCNFSM6AAAAAASUF2LHU>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[sanjayankur31]

Hi Dave,

Thanks very much. That sounds great. I'll keep an eye on the repo and test out updates to ensure it all continues to build on the different Fedora releases.

Cheers,
Ankur