Skip to content

Fix Null Dereference and Privacy Violation issues. #763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Fix Null Dereference and Privacy Violation issues. #763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0a6540
Fix Null Dereference and Privacy Violation issues.
claudiamurialdo Feb 3, 2023
a94088d
Fix Null Dereference
claudiamurialdo Feb 3, 2023
0d3e5b0
Undo changes on FabricConnection. It will be removed.
claudiamurialdo Feb 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dotnet/src/dotnetframework/GxClasses/Data/GXDataMysqlDriverCS.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,6 @@ protected override string BuildConnectionString(string datasourceName, string us
string maxpoolSize = GetParameterValue(connstr, "Max Pool Size");
if (String.IsNullOrEmpty(maxpoolSize)) MAX_TRIES = 100;
else MAX_TRIES = Convert.ToInt32(maxpoolSize);
GXLogging.Debug(log, "MAX_TRIES=" + MAX_TRIES);
return connstr;
}
public override bool AllowsDuplicateParameters
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/extensions/Azure/Handlers/QueueHandler/QueueTriggerHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ private QueueMessage SetupMessage(FunctionContext context, string item)
private void ProcessMessage(FunctionContext context, ILogger log, QueueMessage queueMessage)
{
CallMappings callmap = (CallMappings)_callmappings;
GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;

string exMessage;
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/extensions/Azure/Handlers/ServiceBusHandler/ServiceBusTriggerHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ private Message SetupMessage(FunctionContext context, string item)
private void ProcessMessage(FunctionContext context, ILogger log, Message message)
{
CallMappings callmap = (CallMappings)_callmappings;
GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
GxAzMappings map = (callmap!=null && callmap.mappings is object) ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;

string exMessage;
Expand Down
2 changes: 1 addition & 1 deletion dotnet/src/extensions/Azure/Handlers/TimerHandler/TimerTriggerHandler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ private void ProcessMessage(FunctionContext context, ILogger log, MyInfo TimerIn
CallMappings callmap = (CallMappings)_callmappings;

GxAzMappings map = callmap.mappings is object ? callmap.mappings.First(m => m.FunctionName == context.FunctionDefinition.Name) : null;
string gxProcedure = map is object ? map.GXEntrypoint : string.Empty;
string gxProcedure = (map != null && map is object) ? map.GXEntrypoint : string.Empty;
string exMessage;

if (!string.IsNullOrEmpty(gxProcedure))
Expand Down