Skip to content

Content-type header was not set properly at webservices. #856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
claudiamurialdo merged 1 commit into from
Aug 2, 2023
Merged

Content-type header was not set properly at webservices. #856

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
117 changes: 62 additions & 55 deletions dotnet/src/dotnetframework/GxClasses/Core/GXApplication.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ namespace GeneXus.Application
using Microsoft.AspNetCore.Http;
using GxClasses.Helpers;
using Experimental.System.Messaging;
using Microsoft.Net.Http.Headers;
#endif
using GeneXus.Configuration;
using GeneXus.Metadata;
Expand Down Expand Up @@ -49,6 +48,7 @@ namespace GeneXus.Application
using System.Threading;
using System.Security.Claims;
using System.Security;
using Microsoft.Net.Http.Headers;

public interface IGxContext
{
Expand Down Expand Up @@ -2433,74 +2433,81 @@ private void SetCustomHttpHeader(string name, string value)
{
try
{

#if !NETCORE

switch (name.ToUpper())
{
case "CACHE-CONTROL":
if (CacheControlHeaderValue.TryParse(value, out CacheControlHeaderValue parsedValue))
{
HttpContext.Current.Response.CacheControl = parsedValue.ToString();
}
else
{
var Cache = _HttpContext.Response.Cache;
string[] values = value.Split(',');
foreach (string v in values)
{
switch (v.Trim().ToUpper())
{
case "PUBLIC":
Cache.SetCacheability(HttpCacheability.Public);
break;
case "PRIVATE":
Cache.SetCacheability(HttpCacheability.Private);
break;
case "NO-CACHE":
Cache.SetCacheability(HttpCacheability.NoCache);
break;
case "NO-STORE":
Cache.AppendCacheExtension("no-store, must-revalidate");
break;
default:
GXLogging.Warn(log, String.Format("Could not set Cache Control Http Header Value '{0}' to HttpResponse", value));
break;
}
}
}
break;
default:
_HttpContext.Response.Headers[name] = value;
break;
}
#else
switch (name.ToUpper())

if (name.Equals(HeaderNames.CacheControl, StringComparison.OrdinalIgnoreCase))
{
case "CACHE-CONTROL":
if (CacheControlHeaderValue.TryParse(value, out CacheControlHeaderValue parsedValue))
{
_HttpContext.Response.GetTypedHeaders().CacheControl = parsedValue;
}
else
if (System.Net.Http.Headers.CacheControlHeaderValue.TryParse(value, out System.Net.Http.Headers.CacheControlHeaderValue parsedValue))
{
HttpContext.Current.Response.CacheControl = parsedValue.ToString();
}
else
{
var Cache = _HttpContext.Response.Cache;
string[] values = value.Split(',');
foreach (string v in values)
{
switch (value.ToUpper())
switch (v.Trim().ToUpper())
{
case "PUBLIC":
_HttpContext.Response.AddHeader("Cache-Control", "public");
Cache.SetCacheability(HttpCacheability.Public);
break;
case "PRIVATE":
_HttpContext.Response.AddHeader("Cache-Control", "private");
Cache.SetCacheability(HttpCacheability.Private);
break;
case "NO-CACHE":
Cache.SetCacheability(HttpCacheability.NoCache);
break;
case "NO-STORE":
Cache.AppendCacheExtension("no-store, must-revalidate");
break;
default:
GXLogging.Warn(log, String.Format("Could not set Cache Control Http Header Value '{0}' to HttpResponse", value));
break;
}
}
break;
default:
}
}
else if (name.Equals(HeaderNames.ContentType, StringComparison.OrdinalIgnoreCase))
{
_HttpContext.Response.ContentType = value;
}
else
{
if (!string.IsNullOrEmpty(_HttpContext.Response.Headers[name]))
{
_HttpContext.Response.Headers[name] = value;
}
else
{
_HttpContext.Response.AppendHeader(name, value);
}
}
#else
if (name.Equals(HeaderNames.CacheControl, StringComparison.OrdinalIgnoreCase))
{
if (CacheControlHeaderValue.TryParse(value, out CacheControlHeaderValue parsedValue))
{
_HttpContext.Response.GetTypedHeaders().CacheControl = parsedValue;
}
else
{
switch (value.ToUpper())
{
case "PUBLIC":
_HttpContext.Response.AddHeader(HeaderNames.CacheControl, "public");
break;
case "PRIVATE":
_HttpContext.Response.AddHeader(HeaderNames.CacheControl, "private");
break;
default:
GXLogging.Warn(log, String.Format("Could not set Cache Control Http Header Value '{0}' to HttpResponse", value));
break;
}
}
}
else {
_HttpContext.Response.AddHeader(name, value);
break;
}
#endif
}
Expand Down