Skip to content

Do not PAD (Do Trim) with white spaces when Character Attribute is NULL #260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ggallotti merged 1 commit into from
Aug 20, 2020
Merged

Do not PAD (Do Trim) with white spaces when Character Attribute is NULL #260

ggallotti merged 1 commit into from
Aug 20, 2020

Conversation

@ggallotti
Copy link
Member

@ggallotti ggallotti commented Aug 12, 2020 •
edited
Loading

Issue: 84449

new
	DataItemId = &DataItemId
	DataItemCharacter.SetNull()   
	DataItemVarChar.SetNull()
	DataItemLongVarchar.SetNull()
endnew
do 'Print'


&DataItemId = 2
new
	DataItemId = &DataItemId
	DataItemCharacter.SetEmpty()
	DataItemVarChar.SetEmpty()
	DataItemLongVarchar.SetEmpty()
endnew

Expected Result

TestCase : 1
&DataItemCharacter: ''
&DataItemVarChar: ''
&DataItemLongVarchar: ''
----------------------------------------------------------------------------
TestCase : 2
&DataItemCharacter: '                    '
&DataItemVarChar: ''
&DataItemLongVarchar: ''
Issue: 84449

Actual Result:

TestCase : 1
&DataItemCharacter:  '                    '
&DataItemVarChar: ''
&DataItemLongVarchar: ''
----------------------------------------------------------------------------
TestCase : 2
&DataItemCharacter: '                    '
&DataItemVarChar: ''
&DataItemLongVarchar: ''

@genexusbot
Copy link
Collaborator

genexusbot commented Aug 12, 2020

Cherry pick to beta success

@ggallotti ggallotti requested a review from iroqueta August 12, 2020 16:21
iroqueta
iroqueta reviewed Aug 12, 2020
View reviewed changes
Copy link
Collaborator

@iroqueta iroqueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you change the null case you have to change de not null case too.
Because now the not null case is completed with blanks too

@ggallotti ggallotti merged commit cf52dc3 into master Aug 20, 2020
@ggallotti ggallotti deleted the character-null-empty-padding branch August 20, 2020 13:04
@ggallotti ggallotti changed the title Do not PAD with white spaces when Character Attribute is NULL Do not PAD (Do Trim) with white spaces when Character Attribute is NULL Sep 11, 2020
@ncardeli ncardeli mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iroqueta iroqueta iroqueta left review comments

Assignees

No one assigned

Labels

bot closed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ggallotti @genexusbot @iroqueta @cinthamo