New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumb Enhancements #398

Closed
Jotschi opened this Issue May 2, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@Jotschi
Member

Jotschi commented May 2, 2018

@Jotschi Jotschi added the f/rest label May 2, 2018

@rafacm

This comment has been minimized.

rafacm commented May 3, 2018

From: https://getmesh.io/docs/beta/features.html#_breadcrumbs
genticsmesh-breadcrumb-example

Some thoughts:

Reverse the order of the breadcrumb

When rendering the component, the crumbs will be rendered from top-level (project) node to the bottom (current) node.

Examples:

  1. WAI-ARIA Authoring Practices for the breadcrumb pattern: https://www.w3.org/TR/wai-aria-practices/#breadcrumb (via Bootstrap)
  2. Breadcrumb Example: https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html
    aria-practices-breadcrumb

Include the basenode in the breadcrumb

I would include both the top-level root/project node and the current node

Furthermore, I would make the "breadcrumb" attribute self-contained so that it can be passed to a component and the component can render it without any further REST API requests to Mesh:

  1. Should contain any multi-language information to be rendered in any of the supported languages: https://getmesh.io/docs/beta/features.html#multilanguage
@Jotschi

This comment has been minimized.

Member

Jotschi commented May 3, 2018

@rafacm Keep in mind that is also possible to query the breadcrumb via the GraphQL API. This way you are also able to load different languages and more information.

https://goo.gl/ms8fzW

philippguertler added a commit that referenced this issue Jun 22, 2018

philippguertler added a commit that referenced this issue Jun 22, 2018

philippguertler added a commit to gentics/mesh-ui that referenced this issue Jul 11, 2018

philippguertler added a commit to gentics/mesh-ui that referenced this issue Jul 12, 2018

@Jotschi Jotschi closed this in 212077d Jul 24, 2018

@Jotschi

This comment has been minimized.

Member

Jotschi commented Jul 25, 2018

Fix released in 0.23.0

@Jotschi Jotschi removed this from Must Have in Release 1.0 Estimation Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment