New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node Migration Race Condition #532

Closed
Jotschi opened this Issue Nov 6, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@Jotschi
Member

Jotschi commented Nov 6, 2018

Situation

  1. Create Node
  2. Update schema (with failing migration)
  3. Update schema again (no error since no other node needs migration)
  4. Invoke /api/v1/:project/branches/:branchUuid/migrateSchemas

or

  1. Create Node
  2. Update Schema (with failing migration)
  3. Unassign schema from project
  4. Invoke /api/v1/:project/branches/:branchUuid/migrateSchemas

Issue

An error should be observed because the preparation would create indices for older schema versions which the NodeIndexHandler rejects (since it deems them to no longer be active).

Solutions

  • Ignore NodeIndexHandler checks and create the index.
  • Update NodeIndexHandler to also check for older not migrated nodes (could be a performance issue since all NGFC or SchemaVersions would need to be checked)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment