Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GraphQL name validation #597

Closed
Jotschi opened this issue Dec 12, 2018 · 2 comments

Comments

2 participants
@Jotschi
Copy link
Member

commented Dec 12, 2018

Query is failing:

graphql.AssertException: Name must be non-null, non-empty and match [_A-Za-z][_0-9A-Za-z]*
        at graphql.Assert.assertValidName(Assert.java:57) ~[meshdemo.jar:na]
        at graphql.schema.GraphQLFieldDefinition.<init>(GraphQLFieldDefinition.java:48) ~[meshdemo.jar:na]
        at graphql.schema.GraphQLFieldDefinition$Builder.build(GraphQLFieldDefinition.java:273) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.type.field.FieldDefinitionProvider.createMicronodeDef(FieldDefinitionProvider.java:371) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.type.field.NodeFieldTypeProvider.generateSchemaFieldType(NodeFieldTypeProvider.java:114) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.type.field.NodeFieldTypeProvider.getSchemaFieldsType(NodeFieldTypeProvider.java:43) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.type.NodeTypeProvider.createType(NodeTypeProvider.java:387) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.type.QueryTypeProvider.getRootSchema(QueryTypeProvider.java:455) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.GraphQLHandler.handleQuery(GraphQLHandler.java:57) ~[meshdemo.jar:na]
        at com.gentics.mesh.graphql.GraphQLEndpoint.lambda$registerEndPoints$0(GraphQLEndpoint.java:49) ~[meshdemo.jar:na]
        at io.vertx.ext.web.impl.BlockingHandlerDecorator.lambda$handle$0(BlockingHandlerDecorator.java:48) ~[meshdemo.jar:na]
        at io.vertx.core.impl.ContextImpl.lambda$executeBlocking$1(ContextImpl.java:273) ~[meshdemo.jar:na]
        at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135) ~[na:na]
        at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) ~[na:na]
        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) ~[meshdemo.jar:na]
        at java.base/java.lang.Thread.run(Thread.java:844) ~[na:na]

@mephinet mephinet added this to Must Have in Release 1.0 Estimation Jan 18, 2019

@mephinet mephinet added this to the 1.0.0 milestone Jan 18, 2019

@mephinet mephinet added the quick win label Jan 25, 2019

@Jotschi

This comment has been minimized.

Copy link
Member Author

commented Jan 31, 2019

  • Also check whether the schema name does not conflict with a microschema name. Having two with the same name also causes GraphQL errors.

@Jotschi Jotschi added this to Pending in 1.0 Apr 24, 2019

@Jotschi Jotschi moved this from Pending to Reviewed in 1.0 Apr 24, 2019

@Jotschi

This comment has been minimized.

Copy link
Member Author

commented May 7, 2019

Released with 0.31.5

@Jotschi Jotschi closed this May 7, 2019

@Jotschi Jotschi moved this from Reviewed / Merged to Released in 1.0 May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.