Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range support: "accept-ranges: bytes" not exposed without "Range:" request header #643

Closed
netwarex opened this Issue Feb 4, 2019 · 4 comments

Comments

Projects
None yet
2 participants
@netwarex
Copy link

netwarex commented Feb 4, 2019

Gentics Mesh Version, operating system, or hardware.

  • v0.29.6

Operating System

  • any

JVM

  • any

Problem

Reproducer

curl -sv -H "Range: bytes=0-" https://demo.getmesh.io/api/v1/demo/nodes/df8beb3922c94ea28beb3922c94ea2f6/binary/image > /dev/null
< HTTP/2 206 
< accept-ranges: bytes
< content-disposition: attachment; filename=ford-gt.jpg
< content-encoding: identity
< content-range: bytes 0-530195/530196
< content-type: image/jpeg
< etag: "4728baff"
< webroot-response-type: binary
< content-length: 530196
< date: Mon, 04 Feb 2019 12:48:24 GMT
curl -sv https://demo.getmesh.io/api/v1/demo/nodes/df8beb3922c94ea28beb3922c94ea2f6/binary/image > /dev/null
< HTTP/2 200 
< content-disposition: attachment; filename=ford-gt.jpg
< content-encoding: identity
< content-type: image/jpeg
< etag: "4728baff"
< webroot-response-type: binary
< content-length: 530196
< date: Mon, 04 Feb 2019 12:48:31 GMT

Expected behaviour and actual behaviour

The second curl request also should return the accept-ranges: bytes header

@netwarex netwarex added the bug label Feb 4, 2019

@Jotschi Jotschi added the quick win label Feb 4, 2019

@Jotschi

This comment has been minimized.

Copy link
Member

Jotschi commented Feb 4, 2019

I suspect that only one line needs to be added to include the missing header. That should be all.

@netwarex

This comment has been minimized.

Copy link
Author

netwarex commented Mar 4, 2019

Can we add this in the next 2 weeks? :)

@Jotschi

This comment has been minimized.

Copy link
Member

Jotschi commented Mar 21, 2019

I made a fix for this issue. We can only add this in the binary fields endpoint. It is currently not possible to add this for webroot as well.

@Jotschi

This comment has been minimized.

Copy link
Member

Jotschi commented Mar 22, 2019

Fixed with 0.31.2

@Jotschi Jotschi closed this Mar 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.