Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Templating #10

Closed
wants to merge 6 commits into from
Closed

Templating #10

wants to merge 6 commits into from

Conversation

lu-zero
Copy link
Member

@lu-zero lu-zero commented Jul 29, 2021

  • Convert the current template to tera
  • Add and option to pass a custom template
  • Refactor the template in a base.tera with good defaults and let the user rely on it
  • Document everything

Copy link
Member

@gyakovlev gyakovlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some template comments.
also, can you sign-off commits please?
it's required for gentoo namespace.
I've added a github check for it btw.

src/base.tera Outdated Show resolved Hide resolved
src/base.tera Outdated Show resolved Hide resolved
src/base.tera Outdated Show resolved Hide resolved
src/base.tera Outdated Show resolved Hide resolved
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Custom templates can just implement the blocks they care for

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
@lu-zero
Copy link
Member Author

lu-zero commented Aug 5, 2021

I rebased and updated the template according to your suggestion, let me know if it works for you.

Signed-off-by: Luca Barbato <lu_zero@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants