New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken rule_generator in beta3, master (???) #56

Closed
ssuominengentoo opened this Issue Apr 6, 2013 · 6 comments

Comments

Projects
None yet
2 participants
@ssuominengentoo

ssuominengentoo commented Apr 6, 2013

The following commit is part of beta3, master:

http://cgit.freedesktop.org/systemd/systemd/commit/src/udev?id=97595710b77aa162ca5e20da57d0a1ed7355eaad

This will make it impossible to rename into kernel reserved names like eth0, eth1, wlan0, wlan1, ...

Yet the old rule_generator was brought back. How can it work if the generated rules are getting ignored?

Or are you using now different namespace, free namespace, like lan* and wireless* in the rule_generator? If so, then sorry, I must have missed it.

@blueness

This comment has been minimized.

Show comment
Hide comment
@blueness

blueness Apr 6, 2013

Contributor

I don't think the old rule_generator should have been brought back. Let's see what Ian has to say else I'll just drop it again. I don't want to reintroduce 9759571 because it looks potentially racey.

Contributor

blueness commented Apr 6, 2013

I don't think the old rule_generator should have been brought back. Let's see what Ian has to say else I'll just drop it again. I don't want to reintroduce 9759571 because it looks potentially racey.

@blueness

This comment has been minimized.

Show comment
Hide comment
@blueness

blueness Apr 6, 2013

Contributor

It was brought back conditionally see ENABLE_RULE_GENERATOR in configurea.c. So, either, we need a AC_SUBST and to bracket that code conditionally, or we need to just drop it.

The conservative option may be wisest here.

Contributor

blueness commented Apr 6, 2013

It was brought back conditionally see ENABLE_RULE_GENERATOR in configurea.c. So, either, we need a AC_SUBST and to bracket that code conditionally, or we need to just drop it.

The conservative option may be wisest here.

@blueness

This comment has been minimized.

Show comment
Hide comment
@blueness

blueness Apr 8, 2013

Contributor

I've now added this code conditional on --enable-rule-generator. See df016d6

Contributor

blueness commented Apr 8, 2013

I've now added this code conditional on --enable-rule-generator. See df016d6

@ssuominengentoo

This comment has been minimized.

Show comment
Hide comment
@ssuominengentoo

ssuominengentoo Apr 8, 2013

looks good to me, but I didn't test it, feel free to close this ticket when you want (gentoo-x86 should be fixed too?)

ssuominengentoo commented Apr 8, 2013

looks good to me, but I didn't test it, feel free to close this ticket when you want (gentoo-x86 should be fixed too?)

@blueness

This comment has been minimized.

Show comment
Hide comment
@blueness

blueness Apr 10, 2013

Contributor

eudev-9999 has the fix. i'll push out 1_beta4 later today and close this if there are no problems.

Contributor

blueness commented Apr 10, 2013

eudev-9999 has the fix. i'll push out 1_beta4 later today and close this if there are no problems.

@blueness

This comment has been minimized.

Show comment
Hide comment
@blueness

blueness Apr 11, 2013

Contributor

eudev-1_beta4 is in gentoo-x86.

Contributor

blueness commented Apr 11, 2013

eudev-1_beta4 is in gentoo-x86.

@blueness blueness closed this Apr 11, 2013

rofl0r pushed a commit to rofl0r/eudev-temp that referenced this issue Jan 18, 2014

src/udev/udev-event.c: restore code to allow rule generator to work
This code was dropped while importing from upstream.  It is needed
to allow the legacy renaming of interfaces like eth* or wlan*.

X-Eudev-Bug: 56
X-Eudev-Bug-URL: gentoo/eudev#56
Signed-off-by: Anthony G. Basile <blueness@gentoo.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment