Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-python/rstcheck-3.3.1: Add rstcheck python package #16399

Closed
wants to merge 6 commits into from

Conversation

samuelbernardo
Copy link
Contributor

Signed-off-by: Samuel Bernardo samuelbernardo.mail@gmail.com

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
@samuelbernardo samuelbernardo changed the title Add rstcheck python package dev-python/rstcheck-3.3.1: Add rstcheck python package Jun 24, 2020
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @samuelbernardo
Areas affected: ebuilds
Packages affected: dev-python/rstcheck

dev-python/rstcheck: @gentoo/proxy-maint (new package)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

New packages

This Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). labels Jun 24, 2020
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-3.0.1
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
@samuelbernardo
Copy link
Contributor Author

I did a mistake when pushing to this PR changes from other one. The last two commits shouldn't be here.
I will revert both.

@DarthGandalf
Copy link
Contributor

You need to fix the issues pointed out in CI anyway.

Did you add the package to guru?

This reverts commit 77ebc18.

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
This reverts commit 63ec89c.

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
@samuelbernardo
Copy link
Contributor Author

You need to fix the issues pointed out in CI anyway.

Did you add the package to guru?

Yes, the package rstcheck was added first to guru.
I will look into this now. I think the only requirement is to update version.

@samuelbernardo
Copy link
Contributor Author

samuelbernardo commented Sep 6, 2020

I will look into this now. I think the only requirement is to update version.

rstcheck-3.3.1 is still the latest version.
It as been already approved to guru master branch:
https://github.com/gentoo-mirror/guru/tree/master/dev-python/rstcheck

What I'm missing here?

[update]

EmptyMaintainer no package maintainer or maintainer-needed comment specified

So it seems that is only required some team or official maintainer to pick this I suppose...

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2020-09-06 12:09 UTC
Newest commit scanned: f5862cd
Status: ❌ broken

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/66225eaaa4/output.html#dev-python/rstcheck

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/66225eaaa4/output.html

@mjeveritt
Copy link
Contributor

mjeveritt commented Sep 9, 2020

<veremitz> !note @samuelbernardo you need to add a 'maintainer' section to metadata.xml with your name and often the proxy-maint project too

@ghost
Copy link

ghost commented Jan 12, 2023

@samuelbernardo ping: still interested on that PR?

@samuelbernardolip
Copy link

@samuelbernardo ping: still interested on that PR?

Yes, just miss this. I'm going to correct the missing details.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the meantime rstcheck reaches v6.1.1 https://pypi.org/project/rstcheck/

@@ -0,0 +1,44 @@
# Copyright 1999-2020 Gentoo Authors
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments here and here

# Copyright 1999-2020 Gentoo Authors

# Copyright 1999-2020 Gentoo Authors
# Distributed under the terms of the GNU General Public License v2

EAPI=7
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EAPI=8


EAPI=7

PYTHON_COMPAT=( pypy3 python3_{6,7,8} )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verify if it compiles with PYTHON_COMPAT=( python3_{9..11} pypy3 ). Are you sure it compiles against pypy3?

Comment on lines +20 to +22
RDEPEND="
dev-python/docutils[${PYTHON_USEDEP}]
"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a style fix, one-line it

)
"

S="${WORKDIR}/${P}"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ehm, isn't it already like that?

@samuelbernardo
Copy link
Contributor Author

Closing this PR since it is completely outdated from master and after merge pkgcheck don't allow to use python_3.11.
Will create a new fresh PR for the new release.

@samuelbernardo samuelbernardo deleted the rstcheck branch January 30, 2023 02:09
samuelbernardo added a commit to samuelbernardo/gentoo that referenced this pull request Jan 30, 2023
Applied review suggestions from PR
gentoo#16399

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
samuelbernardo added a commit to samuelbernardo/gentoo that referenced this pull request Jan 30, 2023
Apply review suggestions from PR
gentoo#16399

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
samuelbernardo added a commit to samuelbernardo/gentoo that referenced this pull request Jan 30, 2023
Apply review suggestions from PR
gentoo#16399

Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). new package The PR is adding a new package. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
6 participants