New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dev-python/rstcheck-3.3.1: Add rstcheck python package #16399
Conversation
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Pull Request assignmentSubmitter: @samuelbernardo dev-python/rstcheck: @gentoo/proxy-maint (new package) Linked bugsNo bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment. New packagesThis Pull Request appears to be introducing new packages only. Due to limited manpower, adding new packages is considered low priority. This does not mean that your Pull Request will not receive any attention, however, it might take quite some time for it to be reviewed. In the meantime, your new ebuild might find a home in the GURU project repository: the ebuild repository maintained collaboratively by Gentoo users. GURU offers your ebuild a place to be reviewed and improved by other Gentoo users, while making it easy for Gentoo users to install it and enjoy the software it adds. In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Package-Manager: Portage-3.0.4, Repoman-3.0.1 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
I did a mistake when pushing to this PR changes from other one. The last two commits shouldn't be here. |
You need to fix the issues pointed out in CI anyway. Did you add the package to guru? |
Yes, the package rstcheck was added first to guru. |
rstcheck-3.3.1 is still the latest version. What I'm missing here? [update]
So it seems that is only required some team or official maintainer to pick this I suppose... |
Pull request CI reportReport generated at: 2020-09-06 12:09 UTC New issues caused by PR: There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
@samuelbernardo ping: still interested on that PR? |
Yes, just miss this. I'm going to correct the missing details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the meantime rstcheck reaches v6.1.1 https://pypi.org/project/rstcheck/
@@ -0,0 +1,44 @@ | |||
# Copyright 1999-2020 Gentoo Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments here and here
# Copyright 1999-2020 Gentoo Authors
# Copyright 1999-2020 Gentoo Authors | ||
# Distributed under the terms of the GNU General Public License v2 | ||
|
||
EAPI=7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EAPI=8
|
||
EAPI=7 | ||
|
||
PYTHON_COMPAT=( pypy3 python3_{6,7,8} ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verify if it compiles with PYTHON_COMPAT=( python3_{9..11} pypy3 )
. Are you sure it compiles against pypy3?
RDEPEND=" | ||
dev-python/docutils[${PYTHON_USEDEP}] | ||
" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a style fix, one-line it
) | ||
" | ||
|
||
S="${WORKDIR}/${P}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ehm, isn't it already like that?
Closing this PR since it is completely outdated from master and after merge pkgcheck don't allow to use python_3.11. |
Applied review suggestions from PR gentoo#16399 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Apply review suggestions from PR gentoo#16399 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Apply review suggestions from PR gentoo#16399 Signed-off-by: Samuel Bernardo <samuelbernardo.mail@gmail.com>
Signed-off-by: Samuel Bernardo samuelbernardo.mail@gmail.com