dev-lang/clojure: bumping to new version #19991

ghost · 2021-03-18T17:54:42Z

Bumping to clojure-1.10.3

Package-Manager: Portage-3.0.17, Repoman-3.0.2
Signed-off-by: Marco Scardovi marco@scardovi.com

gentoo-bot · 2021-03-18T17:56:06Z

Pull Request assignment

Submitter: @scardracs
Areas affected: ebuilds
Packages affected: dev-lang/clojure

dev-lang/clojure: @gentoo/proxy-maint (maintainer needed)

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

gentoo-repo-qa-bot · 2021-03-18T18:04:07Z

Pull request CI report

Report generated at: 2021-03-18 18:04 UTC
Newest commit scanned: 5cdb0b2
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/a5624562c2/output.html

gentoo-repo-qa-bot · 2021-03-18T21:54:02Z

Pull request CI report

Report generated at: 2021-03-18 21:54 UTC
Newest commit scanned: 93e6237
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/37106238d4/output.html

gentoo-repo-qa-bot · 2021-03-19T06:28:55Z

Pull request CI report

Report generated at: 2021-03-19 06:28 UTC
Newest commit scanned: d389a9c
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/1af8ae7b8a/output.html

gentoo-repo-qa-bot · 2021-03-19T07:09:01Z

Pull request CI report

Report generated at: 2021-03-19 07:09 UTC
Newest commit scanned: c0b3803
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/8b567e7321/output.html

juippis

You are adding a new version, let the commit summary reflect that too.

dev-lang/clojure/clojure-1.10.3.ebuild

Fixed slot for 1.10.3 in order to prevent the overshadow over 1.10.0 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Marco Scardovi <marco@scardovi.com>

ghost

I should have fixed all the requested changes

gentoo-repo-qa-bot · 2021-03-21T12:23:55Z

Pull request CI report

Report generated at: 2021-03-21 12:23 UTC
Newest commit scanned: ebd4806
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/b126546201/output.html

juippis

Tests don't work. I also get an error when trying to run clojure, but as I don't do java, it might be related to my setup.

# clojure-1.10 
Exception in thread "main" java.lang.ExceptionInInitializerError
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at clojure.lang.RT.classForName(RT.java:2212)
	at clojure.lang.RT.classForName(RT.java:2221)
	at clojure.lang.RT.loadClassForName(RT.java:2240)
	at clojure.lang.RT.load(RT.java:449)
	at clojure.lang.RT.load(RT.java:424)
	at clojure.core$load$fn__8365.invoke(core.clj:6115)
	at clojure.core$load.invokeStatic(core.clj:6114)
	at clojure.core$load.doInvoke(core.clj:6098)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.core$load_one.invokeStatic(core.clj:5897)
	at clojure.core$load_one.invoke(core.clj:5892)
	at clojure.core$load_lib$fn__8305.invoke(core.clj:5937)
	at clojure.core$load_lib.invokeStatic(core.clj:5936)
	at clojure.core$load_lib.doInvoke(core.clj:5917)
	at clojure.lang.RestFn.applyTo(RestFn.java:142)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$load_libs.invokeStatic(core.clj:5974)
	at clojure.core$load_libs.doInvoke(core.clj:5958)
	at clojure.lang.RestFn.applyTo(RestFn.java:137)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$require.invokeStatic(core.clj:5996)
	at clojure.core.server$loading__8246__auto____10374.invoke(server.clj:9)
	at clojure.core.server__init.load(Unknown Source)
	at clojure.core.server__init.<clinit>(Unknown Source)
	at java.lang.Class.forName0(Native Method)
	at java.lang.Class.forName(Class.java:348)
	at clojure.lang.RT.classForName(RT.java:2212)
	at clojure.lang.RT.classForName(RT.java:2221)
	at clojure.lang.RT.loadClassForName(RT.java:2240)
	at clojure.lang.RT.load(RT.java:449)
	at clojure.lang.RT.load(RT.java:424)
	at clojure.core$load$fn__8365.invoke(core.clj:6115)
	at clojure.core$load.invokeStatic(core.clj:6114)
	at clojure.core$load.doInvoke(core.clj:6098)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.core$load_one.invokeStatic(core.clj:5897)
	at clojure.core$load_one.invoke(core.clj:5892)
	at clojure.core$load_lib$fn__8305.invoke(core.clj:5937)
	at clojure.core$load_lib.invokeStatic(core.clj:5936)
	at clojure.core$load_lib.doInvoke(core.clj:5917)
	at clojure.lang.RestFn.applyTo(RestFn.java:142)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$load_libs.invokeStatic(core.clj:5974)
	at clojure.core$load_libs.doInvoke(core.clj:5958)
	at clojure.lang.RestFn.applyTo(RestFn.java:137)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$require.invokeStatic(core.clj:5996)
	at clojure.core$require.doInvoke(core.clj:5996)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.lang.Var.invoke(Var.java:384)
	at clojure.lang.RT.doInit(RT.java:491)
	at clojure.lang.RT.init(RT.java:467)
	at clojure.main.main(main.java:38)
Caused by: Syntax error macroexpanding clojure.core/defn at (clojure/spec/alpha.clj:78:1).
	at clojure.lang.Compiler.checkSpecs(Compiler.java:6976)
	at clojure.lang.Compiler.macroexpand1(Compiler.java:6992)
	at clojure.lang.Compiler.macroexpand(Compiler.java:7079)
	at clojure.lang.Compiler.eval(Compiler.java:7165)
	at clojure.lang.Compiler.load(Compiler.java:7640)
	at clojure.lang.RT.loadResourceScript(RT.java:381)
	at clojure.lang.RT.loadResourceScript(RT.java:372)
	at clojure.lang.RT.load(RT.java:459)
	at clojure.lang.RT.load(RT.java:424)
	at clojure.core$load$fn__8365.invoke(core.clj:6115)
	at clojure.core$load.invokeStatic(core.clj:6114)
	at clojure.core$load.doInvoke(core.clj:6098)
	at clojure.lang.RestFn.invoke(RestFn.java:408)
	at clojure.core$load_one.invokeStatic(core.clj:5897)
	at clojure.core$load_one.invoke(core.clj:5892)
	at clojure.core$load_lib$fn__8305.invoke(core.clj:5937)
	at clojure.core$load_lib.invokeStatic(core.clj:5936)
	at clojure.core$load_lib.doInvoke(core.clj:5917)
	at clojure.lang.RestFn.applyTo(RestFn.java:142)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$load_libs.invokeStatic(core.clj:5974)
	at clojure.core$load_libs.doInvoke(core.clj:5958)
	at clojure.lang.RestFn.applyTo(RestFn.java:137)
	at clojure.core$apply.invokeStatic(core.clj:669)
	at clojure.core$require.invokeStatic(core.clj:5996)
	at clojure.main$loading__8246__auto____10507.invoke(main.clj:11)
	at clojure.main__init.load(Unknown Source)
	at clojure.main__init.<clinit>(Unknown Source)
	... 55 more
Caused by: java.lang.Exception: #object[clojure.spec.alpha$and_spec_impl$reify__1048 0x30af7377 "clojure.spec.alpha$and_spec_impl$reify__1048@30af7377"] is not a fn, expected predicate fn
	at clojure.spec.alpha$dt.invokeStatic(alpha.clj:762)
	at clojure.spec.alpha$dt.invoke(alpha.clj:752)
	at clojure.spec.alpha$dt.invokeStatic(alpha.clj:753)
	at clojure.spec.alpha$dt.invoke(alpha.clj:752)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1527)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1535)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$deriv$fn__1290.invoke(alpha.clj:1537)
	at clojure.core$map$fn__7393.invoke(core.clj:2759)
	at clojure.lang.LazySeq.sval(LazySeq.java:42)
	at clojure.lang.LazySeq.seq(LazySeq.java:51)
	at clojure.lang.RT.seq(RT.java:535)
	at clojure.core$seq__6928.invokeStatic(core.clj:139)
	at clojure.core$map$fn__7400.invoke(core.clj:2767)
	at clojure.lang.LazySeq.sval(LazySeq.java:42)
	at clojure.lang.LazySeq.seq(LazySeq.java:51)
	at clojure.lang.RT.seq(RT.java:535)
	at clojure.core$seq__6928.invokeStatic(core.clj:139)
	at clojure.core$filter$fn__7420.invoke(core.clj:2813)
	at clojure.lang.LazySeq.sval(LazySeq.java:42)
	at clojure.lang.LazySeq.seq(LazySeq.java:51)
	at clojure.lang.RT.seq(RT.java:535)
	at clojure.core$seq__6928.invokeStatic(core.clj:139)
	at clojure.core$map$fn__7393.invoke(core.clj:2750)
	at clojure.lang.LazySeq.sval(LazySeq.java:42)
	at clojure.lang.LazySeq.seq(LazySeq.java:51)
	at clojure.lang.RT.seq(RT.java:535)
	at clojure.core$seq__6928.invokeStatic(core.clj:139)
	at clojure.core$seq__6928.invoke(core.clj:139)
	at clojure.spec.alpha$filter_alt.invokeStatic(alpha.clj:1424)
	at clojure.spec.alpha$filter_alt.invoke(alpha.clj:1418)
	at clojure.spec.alpha$alt_STAR_.invokeStatic(alpha.clj:1428)
	at clojure.spec.alpha$alt_STAR_.invoke(alpha.clj:1427)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1537)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1535)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1536)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$deriv.invokeStatic(alpha.clj:1536)
	at clojure.spec.alpha$deriv.invoke(alpha.clj:1521)
	at clojure.spec.alpha$re_conform.invokeStatic(alpha.clj:1662)
	at clojure.spec.alpha$re_conform.invoke(alpha.clj:1653)
	at clojure.spec.alpha$regex_spec_impl$reify__1374.conform_STAR_(alpha.clj:1703)
	at clojure.spec.alpha$conform.invokeStatic(alpha.clj:164)
	at clojure.spec.alpha$conform.invoke(alpha.clj:160)
	at clojure.spec.alpha$macroexpand_check.invokeStatic(alpha.clj:701)
	at clojure.spec.alpha$macroexpand_check.invoke(alpha.clj:697)
	at clojure.lang.AFn.applyToHelper(AFn.java:156)
	at clojure.lang.AFn.applyTo(AFn.java:144)
	at clojure.lang.Var.applyTo(Var.java:705)
	at clojure.lang.Compiler.checkSpecs(Compiler.java:6974)
	... 82 more

ghost · 2021-03-21T13:16:18Z

@juippis I have tested it and actually works so I don't know what happened. I will do further tests

toshokan · 2021-03-22T16:00:32Z

Unfortunately, starting a clojure repl doesn't work on my machine either.
It looks like this version bump was based on clojure-1.10, but clojure can no longer be built that way.

I investigated this a little while ago but never got to around to making the PR

Since clojure-1.10.1 (specifically since CLJ-2484), spec-alpha can no longer be a source-only-JAR. Upstream does not run into this issue, because their builds use prebuilt maven packages for spec-alpha, so their JARs contain bytecode.

Our dev-java/spec-alpha does not depend on clojure, so we have no way to build anything but a source-only-JAR. Building clojure from source also depends on spec-alpha, so we'd have a dependency cycle if we tried to invert these.

Interestingly though, while clojure requires a precompiled spec-alpha to run interactively/start a repl, it does not require it to just compile clj files (it only requires sources).

I think the way forward will be a simple bootstrapping process

build dev-lang/clojure with spec-alpha on the classpath by downloading its sources from the clojure ebuild
have dev-lang/clojure RDEPEND (but not BDEPEND) on dev-java/spec-alpha
have dev-java/spec-alpha BDEPEND on dev-lang/clojure so we can properly build a JAR with bytecode

ghost · 2021-03-22T17:55:37Z

The thing I don't understand is why it works on my PC without issues and not in others

toshokan · 2021-03-22T18:08:40Z

How did you build dev-java/spec-alpha?

ghost · 2021-03-22T18:10:22Z

@toshokan simply emerging it. I have also made a PR for version bump #20017

toshokan · 2021-03-22T18:24:38Z

Can you check if your spec-alpha jar has .class files in it?

ghost · 2021-03-22T18:36:08Z

@toshokan @juippis ok I can report same error now. I can't before because I hadn't noticed that it was installing the 1.10.0. My bad, sorry

juippis · 2021-03-22T18:55:21Z

dac5816 I've reverted the bump to 1.10.3. This also took you out as a maintainer from metadata.xml, as it was paired with a version bump commit. A good lesson why you should modify metadata.xml becoming a maintainer in a separate commit ;)

I do expect you to figure this out, and become the commit again in a working version bump. Hence I didn't re-assign the bugs to maintainer-needed. Please let me know if you have no intention of working on this package, and I'll assign the bugs properly.

Sorry for the mess, I should get more familiar with java :I

tgbugs · 2021-03-23T03:51:51Z

I think that @toshokan has the assessment of the situation. When I did this originally I specifically hunted down versions that didn't have the bootstrapping problems caused by dependence on maven. Going forward this means that if we want to be able to bootstrap clojure we will likely have to find intermediate versions that can be built using an earlier slot.

ghost · 2021-03-23T05:24:09Z

Can you check if your spec-alpha jar has .class files in it?

At the end I managed to check it and no, no .class file on it

ghost · 2021-03-30T18:29:23Z

@tgbugs @toshokan I have tried to take a look on it but I don't know java so well so I will not able to make it fixed. Also there is a problem on test with 1.10.0 (test is ATM restriced so it is a problem only when run ebuild clojure-1.10.0.ebuild clean test). More info here: https://bugs.gentoo.org/737064

toshokan · 2021-03-30T18:34:51Z

In that case I'd like to take a look at it.

ghost · 2021-03-30T18:38:03Z

@toshokan thanks :) I have requested a stabilization for 1.10.0 before notice the bug on test, so please take a look on it https://bugs.gentoo.org/777264

tgbugs · 2021-03-30T19:17:53Z

IIRC there is no effective way to run the tests for this.
Running FEATURES=test ebuild clojure-1.10.0.ebuild test runs into issues where the classpath that works after merge does not work during testing so you wind up with

     [java] Caused by: java.io.FileNotFoundException: Could not locate clojure/spec/alpha__init.class, clojure/spec/alpha.clj or clojure/spec/alpha.cljc on classpath.

There was not an easy way forward to fix that when I worked on it.

ghost · 2021-03-30T19:24:37Z

@tgbugs so I have to drop stabilization request as test is a common part on it

ghost · 2021-03-30T19:25:53Z

@juippis what you think?

tgbugs · 2021-03-30T19:31:47Z

I would keep it masked because despite the fact that it does install a working clojure repl, there are some caveats, such as the fact that you can't just follow most of the instructions for how to get started with clojure because we don't use the uberjar that has all sorts of stuff bundled. I dug into this a while back, but essentially clojure as a whole has gone the way of maven, so anyone who wants to run these stripped down versions of clojure needs to know what they are doing.

ghost · 2021-03-30T19:39:47Z

It's up to you. I'm drop it as said before because I haven't the knowledge to fix nor I'm able to ask properly upstream what they could do to fix it. I'm sorry if I messed up this so much

toshokan · 2021-03-30T19:42:37Z

A few months ago I found a way to bootstrap a clojure-1.10.1 build without maven and also build the clj cli tools, so hopefully the situation isn't so dire.

ghost · 2021-03-30T19:45:42Z

@toshokan I have dropped request for stabilization so you and @tgbugs have all the time to take a look and try to fix :)

tgbugs · 2021-03-30T19:49:07Z

@toshokan if we can get the clj cli tools in tree that might be the most concrete way forward, pull me in on any bugs/prs related to that if you want.

This is the initial import of the broken ebuild from gentoo/gentoo#19991 (with minor modifications).

Flowdalic · 2021-04-16T10:01:23Z

A few months ago I found a way to bootstrap a clojure-1.10.1 build without maven and also build the clj cli tools, so hopefully the situation isn't so dire.

Care to share what you found? I am also Interessent in a bootstraping solution for clojure (latest version in my case, but I assume it is applicable).

gentoo-bot added maintainer-needed There is at least one affected package with no maintainer. Review it if you can. assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Mar 18, 2021

juippis reviewed Mar 21, 2021

View reviewed changes

dev-lang/clojure/clojure-1.10.3.ebuild Outdated Show resolved Hide resolved

dev-lang/clojure/clojure-1.10.3.ebuild Outdated Show resolved Hide resolved

dev-lang/clojure: fixed slot

ebd4806

Fixed slot for 1.10.3 in order to prevent the overshadow over 1.10.0 Package-Manager: Portage-3.0.17, Repoman-3.0.2 Signed-off-by: Marco Scardovi <marco@scardovi.com>

ghost commented Mar 21, 2021

View reviewed changes

ghost requested a review from juippis March 21, 2021 12:08

juippis approved these changes Mar 21, 2021

View reviewed changes

gentoo-bot closed this in bb90d19 Mar 21, 2021

ghost mentioned this pull request Mar 22, 2021

dev-java/spec-alpha: bumping to new version #20017

Closed

ghost deleted the clojure branch March 27, 2021 15:48

gentoo-repo-qa-bot pushed a commit to gentoo-mirror/flow that referenced this pull request Apr 15, 2021

dev-lang/clojure: initial import of broken ebuild

25db13d

This is the initial import of the broken ebuild from gentoo/gentoo#19991 (with minor modifications).

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dev-lang/clojure: bumping to new version #19991

dev-lang/clojure: bumping to new version #19991

ghost commented Mar 18, 2021 •

edited by ghost

gentoo-bot commented Mar 18, 2021

gentoo-repo-qa-bot commented Mar 18, 2021

gentoo-repo-qa-bot commented Mar 18, 2021

gentoo-repo-qa-bot commented Mar 19, 2021

gentoo-repo-qa-bot commented Mar 19, 2021

juippis left a comment

ghost left a comment

gentoo-repo-qa-bot commented Mar 21, 2021

juippis left a comment

ghost commented Mar 21, 2021 •

edited by ghost

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021 •

edited by ghost

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021 •

edited by ghost

juippis commented Mar 22, 2021

tgbugs commented Mar 23, 2021

ghost commented Mar 23, 2021 •

edited by ghost

ghost commented Mar 30, 2021 •

edited by ghost

toshokan commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

ghost commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

ghost commented Mar 30, 2021

toshokan commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

Flowdalic commented Apr 16, 2021

dev-lang/clojure: bumping to new version #19991

dev-lang/clojure: bumping to new version #19991

Conversation

ghost commented Mar 18, 2021 • edited by ghost

gentoo-bot commented Mar 18, 2021

Pull Request assignment

Linked bugs

gentoo-repo-qa-bot commented Mar 18, 2021

Pull request CI report

gentoo-repo-qa-bot commented Mar 18, 2021

Pull request CI report

gentoo-repo-qa-bot commented Mar 19, 2021

Pull request CI report

gentoo-repo-qa-bot commented Mar 19, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

ghost left a comment

Choose a reason for hiding this comment

gentoo-repo-qa-bot commented Mar 21, 2021

Pull request CI report

juippis left a comment

Choose a reason for hiding this comment

ghost commented Mar 21, 2021 • edited by ghost

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021 • edited by ghost

toshokan commented Mar 22, 2021

ghost commented Mar 22, 2021 • edited by ghost

juippis commented Mar 22, 2021

tgbugs commented Mar 23, 2021

ghost commented Mar 23, 2021 • edited by ghost

ghost commented Mar 30, 2021 • edited by ghost

toshokan commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

ghost commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

ghost commented Mar 30, 2021

toshokan commented Mar 30, 2021

ghost commented Mar 30, 2021

tgbugs commented Mar 30, 2021

Flowdalic commented Apr 16, 2021

ghost commented Mar 18, 2021 •

edited by ghost

ghost commented Mar 21, 2021 •

edited by ghost

ghost commented Mar 22, 2021 •

edited by ghost

ghost commented Mar 22, 2021 •

edited by ghost

ghost commented Mar 23, 2021 •

edited by ghost

ghost commented Mar 30, 2021 •

edited by ghost