sys-apps/hwloc: cuda useflag now required for nvml #21608
Conversation
Pull Request assignmentSubmitter: @Alessandro-Barbieri sys-apps/hwloc: @gentoo/cluster Linked bugsBugs linked: 792477 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
gentoo-bot
added
assigned
Pull request CI reportReport generated at: 2021-07-12 06:59 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
sys-apps/hwloc/hwloc-2.3.0.ebuild
Outdated
| @@ -40,6 +40,7 @@ BDEPEND=" | |||
| virtual/pkgconfig | |||
| " | |||
|
|
|||
| REQUIRED_USE="nvml? ( cuda )" | |||
There was a problem hiding this comment.
I'm not familiar with this package, but I don't really see why the nvml flag needs to exist if it requires cuda, seems redundant. cuda also ensures the drivers are installed, although /if/ it directly links with nvidia-drivers libraries (haven't checked) it may need a := on drivers for safety (unsure how stable this is from major driver to versions to the next with nvml, maybe not needed).
Edit: Unless there's a reason to enable one and disable the other, in which case it should add cuda deps to nvml rather than REQUIRED_USE (and mask in stable like cuda) -- albeit not sure that's worth it.
There was a problem hiding this comment.
In a future, cuda may work on amd hardware
Alessandro-Barbieri
force-pushed
the
hwloc
branch
2 times, most recently
from
a5a119b
to
97acf32
Compare
|
CI failure needs fixing and/or rebase the PR. |
|
I'm not sure on what to mask to make the CI happy |
Closes: https://bugs.gentoo.org/792477 Package-Manager: Portage-3.0.20, Repoman-3.0.3 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Alessandro-Barbieri
force-pushed
the
hwloc
branch
from
97acf32
to
9617f2a
Compare
Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Closes: https://bugs.gentoo.org/796797 Package-Manager: Portage-3.0.28, Repoman-3.0.3 Signed-off-by: Alessandro Barbieri <lssndrbarbieri@gmail.com>
Pull request CI reportReport generated at: 2021-10-20 03:40 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Pull request CI reportReport generated at: 2021-10-20 03:55 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
|
Ping |
You haven’t replied to ionen? |
Closes: https://bugs.gentoo.org/792477
Package-Manager: Portage-3.0.20, Repoman-3.0.3
Signed-off-by: Alessandro Barbieri lssndrbarbieri@gmail.com