Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

www-servers/lighttpd: Bump to version 1.4.63 #23857

Closed
wants to merge 1 commit into from
Closed

www-servers/lighttpd: Bump to version 1.4.63 #23857

wants to merge 1 commit into from

Conversation

ObserverHerb
Copy link
Contributor

Migrate to meson build system.

Not sure how we want to handle html documentation. This isn't part of upstream's meson migration yet and it doesn't seem like a great idea to run the old configure just for docs. Removed block that builds html docs for time being.

Migrate to meson build system.
Remove libev dependency.

Package-Manager: Portage-3.0.28, Repoman-3.0.3
Bug: https://bugs.gentoo.org/820755
Signed-off-by: Herb Miller Jr <herb@hlmjr.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @herbmillerjr
Areas affected: ebuilds
Packages affected: www-servers/lighttpd

www-servers/lighttpd: @herbmillerjr, @gentoo/proxy-maint

Linked bugs

Bugs linked: 820755


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else) assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Jan 18, 2022
@ObserverHerb
Copy link
Contributor Author

FYI - Due to https://bugs.gentoo.org/830691, we may want to delay merging this pull request.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-01-18 17:28 UTC
Newest commit scanned: 8e94b30
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/db5986105d/output.html

@gstrauss
Copy link
Contributor

gstrauss commented Jan 20, 2022

FYI: lighttpd 1.4.64 has been released, including the fix for CVE-2022-22707, which may affect rare configs.

lighttpd 1.4.64 defaults to using pcre2 (and pcre2 has been available as an option since lighttpd 1.4.62). Please migrate gentoo to prefer pcre2 over pcre. If pcre is required, then the build must explicitly specify -Dwith_pcre=true

lighttpd 1.4.64 removes long-deprecated modules. The dependencies on gdbm and memcached have been removed. It is also recommended that the dependency on bzip2 for mod_deflate be disabled by default.

@herbmillerjr wrote:

Not sure how we want to handle html documentation. This isn't part of upstream's meson migration yet and it doesn't seem like a great idea to run the old configure just for docs.

patches welcome upstream. What would you like to see?

Similarly, if you find your patch to meson.build for lua detection useful, please submit it upstream. I am considering changing the search order to look for 'lua' before looking for specific versions.

Edit: references to mod_cml and mod_trigger_b4_dl could be removed from www-servers/lighttpd/files/conf/lighttpd.conf

@thesamesam thesamesam self-requested a review January 20, 2022 18:44
lighttpd-git pushed a commit to lighttpd/lighttpd1.4 that referenced this pull request Jan 21, 2022
@gstrauss
Copy link
Contributor

@gstrauss
Copy link
Contributor

gstrauss commented Jan 24, 2022

@herbmillerjr this PR is back on your plate. I think that lighttpd upstream (git master branch) incorporates most of the changes proposed here.

You correctly point out that lighttpd upstream does not include a doc/meson.build
If you would like to propose a doc/meson.build to lighttpd upstream, I will gladly review it.

Edit: lighttpd in gentoo has been bumped to lighttpd 1.4.64, so this PR should re-focus on migration from autotools to meson build for the lighttpd package.

@ObserverHerb
Copy link
Contributor Author

Going to close this for now since 1.4.64 was completed in another PR. I'll continue to tackle the meson migration and open a PR with the next version bump.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. self-maintained The PR changes only packages that are maintained by the submitter (i.e. no need to ask anybody else)
Projects
None yet
4 participants