Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sci-astronomy/pal: Bump to 0.9.8 and EAPI 8 #26049

Closed
wants to merge 2 commits into from

Conversation

thamognya
Copy link
Contributor

Signed-off-by: Thamognya Kodi contact@thamognya.com

Signed-off-by: Thamognya Kodi <contact@thamognya.com>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @thamognya
Areas affected: ebuilds
Packages affected: sci-astronomy/pal

sci-astronomy/pal: @gentoo/sci-astronomy

Linked bugs

No bugs to link found. If your pull request references any of the Gentoo bug reports, please add appropriate GLEP 66 tags to the commit message and request reassignment.

If you do not receive any reply to this pull request, please open or link a bug to attract the attention of maintainers.


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Jun 23, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-06-23 00:54 UTC
Newest commit scanned: 5f8a7de
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/9ce1d5ad23/output.html

LICENSE="GPL-2"
SLOT="0"
KEYWORDS="~amd64 ~x86 ~amd64-linux ~x86-linux"
IUSE="doc static-libs"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The doc use flag is not doing anything in this ebuild, lets remove it.


if ! use static-libs; then
find "${ED}" -name '*.la' -delete || die
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting some warnings:

* QA Notice: The ebuild is installing to one or more unexpected paths:
* 
*   /usr/docs
*   /usr/manifests
*   /usr/news
* 
* Please fix the ebuild to use correct FHS/Gentoo policy paths.

We should either move these files into /usr/share/doc/${PF} or use dodoc on these files and then just remove them from the wrong location.

Signed-off-by: Thamognya Kodi <contact@thamognya.com>
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-07-21 01:40 UTC
Newest commit scanned: c7f71d6
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/cf72665912/output.html

@AndrewAmmerlaan
Copy link
Member

Thanks 👍

Merged in f2d300e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits.
Projects
None yet
4 participants