Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ~arm64 to media-gfx/freecad #28351

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

NeddySeagoon
Copy link
Contributor

That's better.

DCO added.
sci-mathematics/cgal-5.5 removed ~arm64 keyword to allow media-gfx/openscad-2021.01-r4 to build.
Added build patches and ~arm64 keyword to dev-libs/OpenNI2-2.2_beta2-r1
p.u.m opennni

Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
Bug: https://bugs.gentoo.org/881653
Signed-off-by: Roy Bamford <neddyseagoon@gentoo.org>
@gentoo-bot
Copy link

Pull Request assignment

Submitter: @NeddySeagoon
Areas affected: ebuilds, profiles
Packages affected: dev-libs/OpenNI2, dev-python/pivy, media-gfx/freecad, media-libs/SoQt, media-libs/quarter...

@gentoo/github: Too many disjoint maintainers, disabling auto-assignment.

Linked bugs

Bugs linked: 881653


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added need assignment It was impossible to assign the PR correctly. Please assign it manually. bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Nov 20, 2022
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2022-11-20 15:58 UTC
Newest commit scanned: 0994d7f
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/3925f8113c/output.html

@NeddySeagoon NeddySeagoon changed the title Freecad2 Add ~arm64 to media-gfx/freecad Nov 20, 2022
@NeddySeagoon
Copy link
Contributor Author

This PR needs to be updated now that bug 881995 is fixed.
I should get to that by the weekend.

@darkbasic
Copy link
Contributor

What's the difference with #28344 ?
I see ppc is being mentioned in the patches, does it mean it finally builds on ppc64 as well?

@NeddySeagoon
Copy link
Contributor Author

https://bugs.gentoo.org/886101 suggests that PPC is supported too.
I've had two goes at the ~arm64 freecad keyword. The first one was without opencascade support.
Then opencascade was fixed, so I had another go. Now I have arm64 hardware problems. My arm64 system won't run for more than about 2 hours. Its up and doing an update right now. Once that's done I'll have another go at freecad ~arm64.

@darkbasic
Copy link
Contributor

darkbasic commented Dec 22, 2022

I confirm the dev-libs/OpenNI2 patch fixes it for ppc64le as well:
image

On ppc64 you have to unmask plenty of packages which lack a keyword:

media-gfx/freecad * ~*
dev-libs/OpenNI2 *
sci-libs/flann *
sci-libs/med *
sci-libs/opencascade *
sci-libs/orocos_kdl *
sci-libs/vtk *
media-gfx/openscad *
dev-python/pivy *
dev-python/pyside2 *
dev-python/shiboken2 *
dev-qt/qtquickcontrols2 *
media-libs/quarter *
media-gfx/opencsg *
media-libs/lib3mf *
sci-mathematics/cgal *
x11-libs/qscintilla *
dev-go/act *
sci-libs/kissfft *
dev-tcltk/itcl *
dev-tcltk/itk *

If this is something that can be done I will open a similar PR to do so.

I've also noticed the following while using the amd64 stable versions:

WARNING: One or more updates/rebuilds have been skipped due to a dependency conflict:

sci-libs/hdf5:0

  (sci-libs/hdf5-1.12.2-r4:0/1.12.2::gentoo, ebuild scheduled for merge) USE="fortran hl zlib -cxx -debug -examples -mpi -szip -threads -unsupported" conflicts with
    <sci-libs/hdf5-1.12:=[-mpi] required by (sci-libs/vtk-9.0.3-r7:0/9.0::gentoo, ebuild scheduled for merge) USE="X boost json openmp python qt5 rendering -all-modules (-cuda) -doc -examples -ffmpeg -gdal -imaging -java -kits (-mpi) -mysql -odbc -offscreen -pegtl -postgres -tbb -test -theora -tk -views -web" PYTHON_SINGLE_TARGET="python3_10 -python3_8 -python3_9" VIDEO_CARDS="(-nvidia)"
    ^              ^^^^

sci-libs/hdf5-1.12 is stable but sci-libs/vtk-9.1 isn't. It probably makes sense trying to stabilize sci-libs/vtk-9.1, but it requires the following:

=sci-libs/vtk-9.1* ~*
sci-libs/cgnslib *
=sci-libs/cgnslib-4.3* ~*
dev-libs/pegtl *

sci-libs/cgnslib hdf5
sci-libs/gdal python

That's what I ended up using (portage is already slow enough without having to deal with skipped updates on a daily basis).

@darkbasic
Copy link
Contributor

Is there anything I can do to help get this merged? I'm using these patches on ppc64le since several months and freecad works fine.

@NeddySeagoon
Copy link
Contributor Author

darkbasic,

kicad and freecad want different versions of opencascade, so its not possible to build both concurrently with opencascade support. The bug for freecad on ~arm64 is at https://bugs.gentoo.org/881653.

It is possible to build both with the same opencascade but its not endorsed by upstream, or at least, it wasn't.
As the PR is now, it makes that unsupported change. I'm reluctant to try go ahead with that.

@darkbasic
Copy link
Contributor

darkbasic commented Feb 23, 2023

kicad and freecad want different versions of opencascade, so its not possible to build both concurrently with opencascade support

Ouch, I was planning to give kicad a try on ppc64 later today and I didn't know about this.

What I do not understand is why this should prevent updating the dev-libs/OpenNI2 ebuild with the arm/ppc patches or even keywording freecad. Isn't it an issue on all arches?

@NeddySeagoon
Copy link
Contributor Author

The dev-libs/OpenNI2 part can go ahead separately. My PR is/was for the whole freecad on ~arm64.

@darkbasic
Copy link
Contributor

The dev-libs/OpenNI2 part can go ahead separately. My PR is/was for the whole freecad on ~arm64.

Sure but except for the OpenNI2 patches all your PR does is keywording. All these packages were already keyworded on amd64 so I don't see how the "cannot build kicad and freecad at the same time" issue should prevent keywording on arm64: if that is an issue it should be an issue on amd64 as well and it didn't prevent amd64 from being keyworded. Am I getting something wrong?

@NeddySeagoon
Copy link
Contributor Author

darkbasic,

You are correct. I'm a 'twit'.
I'll try to look at it again over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug linked Bug/Closes found in footer, and cross-linked with the PR. need assignment It was impossible to assign the PR correctly. Please assign it manually.
Projects
None yet
4 participants