Add SMTPUTF8 support for qmail (RFC 6531 and 6532) #2839

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
6 participants
@arnt
Contributor

arnt commented Nov 15, 2016

No description provided.

@arnt

This comment has been minimized.

Show comment
Hide comment
@arnt

arnt Nov 15, 2016

Contributor

Once I've gotten the formalia right and this PR has been merged I'd like to do a few related things...

I noticed libidn2 is old, it could do with an upgrade. And wouldn't it be gentooish to have a general flag to say "I want support for addresses like jøran@blåbærsyltet.øy" and all the relevant mail -packages would follow along?

Contributor

arnt commented Nov 15, 2016

Once I've gotten the formalia right and this PR has been merged I'd like to do a few related things...

I noticed libidn2 is old, it could do with an upgrade. And wouldn't it be gentooish to have a general flag to say "I want support for addresses like jøran@blåbærsyltet.øy" and all the relevant mail -packages would follow along?

@SoapGentoo

This comment has been minimized.

Show comment
Hide comment
@SoapGentoo

SoapGentoo Nov 15, 2016

Member

@arnt Please fix your COMMITMSGs. Have a look at our Github guide: https://wiki.gentoo.org/wiki/Gentoo_Github

Member

SoapGentoo commented Nov 15, 2016

@arnt Please fix your COMMITMSGs. Have a look at our Github guide: https://wiki.gentoo.org/wiki/Gentoo_Github

@arnt

This comment has been minimized.

Show comment
Hide comment
@arnt

arnt Nov 16, 2016

Contributor

@SoapGentoo Should be better now.

Contributor

arnt commented Nov 16, 2016

@SoapGentoo Should be better now.

@monsieurp

This comment has been minimized.

Show comment
Hide comment
@arnt

This comment has been minimized.

Show comment
Hide comment
@arnt

arnt Nov 22, 2016

Contributor

FWIW, I can take care of this package and fix any breakage in the coming years.

Makes sense, really. After all, when something needed doing now I was the person who ended up doing it.

Contributor

arnt commented Nov 22, 2016

FWIW, I can take care of this package and fix any breakage in the coming years.

Makes sense, really. After all, when something needed doing now I was the person who ended up doing it.

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Nov 23, 2016

Contributor

Why did you drop so many keywords?

-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"
+KEYWORDS="amd64 ~arm ~hppa ~ppc ~ppc64 ~x86"

Please re-add them.

Contributor

robbat2 commented Nov 23, 2016

Why did you drop so many keywords?

-KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"
+KEYWORDS="amd64 ~arm ~hppa ~ppc ~ppc64 ~x86"

Please re-add them.

+
+LICENSE="public-domain"
+SLOT="0"
+KEYWORDS="amd64 ~arm ~hppa ~ppc ~ppc64 ~x86"

This comment has been minimized.

@robbat2

robbat2 Nov 23, 2016

Contributor

Re-add the keywords here, and it should ALSO not go straight to stable.

@robbat2

robbat2 Nov 23, 2016

Contributor

Re-add the keywords here, and it should ALSO not go straight to stable.

This comment has been minimized.

@arnt

arnt Nov 24, 2016

Contributor

I removed them because I added a shared library, libidn2, and thus needed to restrict the platform dependencies to those of libidn2. From just a quick glance I couldn't tell why libidn2's list is that short.

As I mentioned, libidn2 needs an update anyway and I wanted to do that. As part of that I'll look closer at which platforms really are excluded by its source code and change both its platform list and that of qmail. But after merging this, please.

I've re-added RESTRICT=TEST.

@arnt

arnt Nov 24, 2016

Contributor

I removed them because I added a shared library, libidn2, and thus needed to restrict the platform dependencies to those of libidn2. From just a quick glance I couldn't tell why libidn2's list is that short.

As I mentioned, libidn2 needs an update anyway and I wanted to do that. As part of that I'll look closer at which platforms really are excluded by its source code and change both its platform list and that of qmail. But after merging this, please.

I've re-added RESTRICT=TEST.

This comment has been minimized.

@robbat2

robbat2 Nov 24, 2016

Contributor

libidn2-0.11 has:

KEYWORDS="alpha amd64 arm hppa ~mips ppc ppc64 x86"

netqmail-1.06-r4 has:

KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"

Based on the intersection of those, and that a bump should not go direct to stable, your netqmail-1.06-r5 should have:

KEYWORDS="~alpha ~amd64 ~arm ~hppa ~mips ~ppc ~ppc64   ~x86"

And we need to file a bug for keywording requests for libidn2-0.11 on the following arches: ~ia64 ~m68k ~s390 ~sh ~sparc (I'll do this part in the meantime while you fix your commit).

@robbat2

robbat2 Nov 24, 2016

Contributor

libidn2-0.11 has:

KEYWORDS="alpha amd64 arm hppa ~mips ppc ppc64 x86"

netqmail-1.06-r4 has:

KEYWORDS="~alpha ~amd64 ~arm ~hppa ~ia64 ~m68k ~mips ~ppc ~ppc64 ~s390 ~sh ~sparc ~x86"

Based on the intersection of those, and that a bump should not go direct to stable, your netqmail-1.06-r5 should have:

KEYWORDS="~alpha ~amd64 ~arm ~hppa ~mips ~ppc ~ppc64   ~x86"

And we need to file a bug for keywording requests for libidn2-0.11 on the following arches: ~ia64 ~m68k ~s390 ~sh ~sparc (I'll do this part in the meantime while you fix your commit).

This comment has been minimized.

@arnt

arnt Nov 25, 2016

Contributor

Done.

I seem to remember getting errors for at least alpha from the bot, but I can't find the report... maybe I made a mistake. I hope so. If not the bot will surely tell me quickly enough ;)

@arnt

arnt Nov 25, 2016

Contributor

Done.

I seem to remember getting errors for at least alpha from the bot, but I can't find the report... maybe I made a mistake. I hope so. If not the bot will surely tell me quickly enough ;)

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Nov 24, 2016

Contributor

https://bugs.gentoo.org/show_bug.cgi?id=600682 covers libidn2 keywording.

You also claimed it was out of date, but the latest on the GNU mirrors is libidn2-0.11, which matches the ebuild. Do you see a newer version somewhere else?

Contributor

robbat2 commented Nov 24, 2016

https://bugs.gentoo.org/show_bug.cgi?id=600682 covers libidn2 keywording.

You also claimed it was out of date, but the latest on the GNU mirrors is libidn2-0.11, which matches the ebuild. Do you see a newer version somewhere else?

@arnt

This comment has been minimized.

Show comment
Hide comment
@arnt

arnt Nov 24, 2016

Contributor

I think I understand now why gentoo has 0.11 ;)

Simon Josefsson wrote that, and 0.2 and 0.3 are available at josefsson.org/libidn2/releases/

Contributor

arnt commented Nov 24, 2016

I think I understand now why gentoo has 0.11 ;)

Simon Josefsson wrote that, and 0.2 and 0.3 are available at josefsson.org/libidn2/releases/

mail-mta/netqmail: Add SMTPUTF8 support for qmail
SMTPUTF8 (RFCs 6531 and 6532, plus several that aren't relevant to qmail)
allows using unencoded UTF8 almost everywhere in email, including in
localparts, domains, subjects and message bodies.

Thanks to cnnic.cn for sponsoring this work.
@gentoo-repo-qa-bot

This comment has been minimized.

Show comment
Hide comment
@gentoo-repo-qa-bot

gentoo-repo-qa-bot Nov 25, 2016

Collaborator

😞 The QA check for this pull request has found the following issues:

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/7c2976f20/output.html#mail-mta/netqmail

Collaborator

gentoo-repo-qa-bot commented Nov 25, 2016

😞 The QA check for this pull request has found the following issues:

New issues caused by PR:
https://qa-reports.gentoo.org/output/gentoo-ci/7c2976f20/output.html#mail-mta/netqmail

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Nov 27, 2016

Contributor

@mgorny ping.
I'm not sure why the QA bot claims NonsolvableDeps for alpha in this case. There's no mask in profiles/, or anything else I can see that should account for it. Either it's a false positive, or I'm missing something.

NonsolvableDeps	nonsolvable depset(depends) keyword(~alpha) profile (default/linux/alpha/13.0): solutions: [ net-dns/libidn2 ]

The keywords on net-libs/libidn2-0.11 are:

KEYWORDS="alpha amd64 arm hppa ~mips ppc ppc64 x86"
Contributor

robbat2 commented Nov 27, 2016

@mgorny ping.
I'm not sure why the QA bot claims NonsolvableDeps for alpha in this case. There's no mask in profiles/, or anything else I can see that should account for it. Either it's a false positive, or I'm missing something.

NonsolvableDeps	nonsolvable depset(depends) keyword(~alpha) profile (default/linux/alpha/13.0): solutions: [ net-dns/libidn2 ]

The keywords on net-libs/libidn2-0.11 are:

KEYWORDS="alpha amd64 arm hppa ~mips ppc ppc64 x86"
@mgorny

This comment has been minimized.

Show comment
Hide comment
@mgorny

mgorny Nov 27, 2016

Member

@robbat2, my guess would be that this pull request precedes ~alpha keywords on libidn2, i.e. needs to be rebased.

Member

mgorny commented Nov 27, 2016

@robbat2, my guess would be that this pull request precedes ~alpha keywords on libidn2, i.e. needs to be rebased.

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Nov 27, 2016

Contributor

Ah, yes, but only just, and it wasn't rebased since the first version.

Contributor

robbat2 commented Nov 27, 2016

Ah, yes, but only just, and it wasn't rebased since the first version.

@robbat2

This comment has been minimized.

Show comment
Hide comment
@robbat2

robbat2 Nov 27, 2016

Contributor

[master 656ae3d] mail-mta/netqmail: Add SMTPUTF8 support for qmail
Author: Arnt Gulbrandsen arnt@gulbrandsen.priv.no
Date: Tue Nov 15 14:20:37 2016 +0000
3 files changed, 426 insertions(+)
create mode 100644 mail-mta/netqmail/files/qmail-smtputf8.patch
create mode 100644 mail-mta/netqmail/netqmail-1.06-r5.ebuild

Contributor

robbat2 commented Nov 27, 2016

[master 656ae3d] mail-mta/netqmail: Add SMTPUTF8 support for qmail
Author: Arnt Gulbrandsen arnt@gulbrandsen.priv.no
Date: Tue Nov 15 14:20:37 2016 +0000
3 files changed, 426 insertions(+)
create mode 100644 mail-mta/netqmail/files/qmail-smtputf8.patch
create mode 100644 mail-mta/netqmail/netqmail-1.06-r5.ebuild

@robbat2 robbat2 closed this Nov 27, 2016

@arnt

This comment has been minimized.

Show comment
Hide comment
@arnt

arnt Nov 28, 2016

Contributor

Thanks. A very pleasant experience.

Contributor

arnt commented Nov 28, 2016

Thanks. A very pleasant experience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment