Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

media-libs/avidemux-core: Fix build error with clang 16 #29971

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

listout
Copy link
Contributor

@listout listout commented Mar 7, 2023

Fixes non-constant-expression cannot be narrowed from type 'uint32_t' error.
Closes: https://bugs.gentoo.org/877121

@listout
Copy link
Contributor Author

listout commented Mar 7, 2023

I'm going to send this patch upstream and get it reviewed there too.
Refer: mean00/avidemux2#481

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-07 08:03 UTC
Newest commit scanned: 0f64e6d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/40f7412456/output.html

Fixes non-constant-expression cannot be narrowed from type 'uint32_t' error.

Closes: https://bugs.gentoo.org/877121
Signed-off-by: brahmajit das <brahmajit.xyz@gmail.com>
@listout listout changed the title media-libs/avidemux-core: Fixes non-constant-expression cannot be nar… media-libs/avidemux-core: Fix build error with clang 16 Mar 7, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-03-07 08:23 UTC
Newest commit scanned: 8d362f5
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/523bafdf5e/output.html

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: media-libs/avidemux-core

media-libs/avidemux-core: @gentoo/video

Linked bugs

Bugs linked: 877121


In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of ConductCopyright policy (expl.) ● DevmanualGitHub PRsProxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels Mar 8, 2023
@listout
Copy link
Contributor Author

listout commented Mar 16, 2023

Upstream merged my PR. We can do a version bump now instead of merging this.

@thesamesam
Copy link
Member

Upstream merged my PR. We can do a version bump now instead of merging this.

Go for it? :)

@@ -0,0 +1,16 @@
# Fixes non-constant-expression cannot be narrowed from type 'uint32_t' error
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No link to the upstream PR here...?

cmake_src_configure
}

src_compile() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can actually be dropped, it'll work the same without. Ditto src_install.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
4 participants