Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net-nds/gssproxy: Fix build with musl llvm #31238

Closed
wants to merge 1 commit into from
Closed

net-nds/gssproxy: Fix build with musl llvm #31238

wants to merge 1 commit into from

Conversation

listout
Copy link
Contributor

@listout listout commented May 31, 2023

@gentoo-bot
Copy link

Pull Request assignment

Submitter: @listout
Areas affected: ebuilds
Packages affected: net-nds/gssproxy

net-nds/gssproxy: @gentoo/base-system

Linked bugs

Bugs linked: 898064

In order to force reassignment and/or bug reference scan, please append [please reassign] to the pull request title.

Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide

@gentoo-bot gentoo-bot added assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR. labels May 31, 2023
@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-31 05:18 UTC
Newest commit scanned: 0a75c6d
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/db51186b2c/output.html

@orbea
Copy link
Contributor

orbea commented May 31, 2023

Small suggestion, but adding the upstreamed commit url to the patch file and adding Upstream-PR: and Upstream-Commit: to the commit message would make it clearer this is merged upstream. :)

@listout
net-nds/gssproxy: Fix build with musl llvm
710ba06 
Upstream-Commit: gssapi/gssproxy@f6ab319
Closes: https://bugs.gentoo.org/898064
Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
@listout listout force-pushed the gssproxy-musl-llvm16-build-fix branch from 0a75c6d to 710ba06 Compare May 31, 2023 13:36
@listout
Copy link
Contributor Author

listout commented May 31, 2023

Small suggestion, but adding the upstreamed commit url to the patch file and adding Upstream-PR: and Upstream-Commit: to the commit message would make it clearer this is merged upstream. :)

done 👍

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull request CI report

Report generated at: 2023-05-31 13:48 UTC
Newest commit scanned: 710ba06
Status: ✅ good

There are existing issues already. Please look into the report to make sure none of them affect the packages in question:
https://qa-reports.gentoo.org/output/gentoo-ci/5f92baef1b/output.html

@listout
Copy link
Contributor Author

listout commented Jun 17, 2023 •
edited

ping! upstream is commit is merged

cc: @juippis @thesamesam can you take a look, thanks in advance.

juippis
juippis approved these changes Jun 18, 2023
View reviewed changes
Copy link
Member

@juippis juippis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this patch works with clang:16 and/or musl+clang:16. I'm not eligible to merge @gentoo/base-system packages though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juippis juippis juippis approved these changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). bug linked Bug/Closes found in footer, and cross-linked with the PR.
Projects
None yet
Milestone
No milestone
5 participants
@listout @gentoo-bot @gentoo-repo-qa-bot @orbea @juippis