Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev-perl/mime-construct: add "Date" field to generated messages #3408

Closed
wants to merge 1 commit into from
Closed

dev-perl/mime-construct: add "Date" field to generated messages #3408

wants to merge 1 commit into from

Conversation

maciejsszmigiero
Copy link
Contributor

Currently, mime-construct does not include the "Date" field in generated
messages.

The "Date" field is required according to the RFC 5322 and not every MTA or
SMTP client adds it when it is missing (for example mail-mta/msmtp does not
do it).

Mail clients often timestamp messages lacking this field as either
01.01.1970 or a date the message was first seen by a particular client
rather than as an actual posting date.

This issue was reported upstream a year ago but there was no response - the
software had last release in 2010 so it is probably no longer maintained.

That's why we have to add the missing field ourselves.

Gentoo-Bug: https://bugs.gentoo.org/583882
Package-Manager: Portage-2.3.3, Repoman-2.3.1

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: dev-perl/mime-construct

dev-perl/mime-construct: @gentoo/Perl

@gentoo-repo-qa-bot gentoo-repo-qa-bot added the assigned PR successfully assigned to the package maintainer(s). label Jan 9, 2017
@kentfredric
Copy link
Contributor

What's the point of the eutils inherit?

Currently, mime-construct does not include the "Date" field in generated
messages.

The "Date" field is required according to the RFC 5322 and not every MTA or
SMTP client adds it when it is missing (for example mail-mta/msmtp does not
do it).

Mail clients often timestamp messages lacking this field as either
01.01.1970 or a date the message was first seen by a particular client
rather than as an actual posting date.

This issue was reported upstream a year ago but there was no response - the
software had last release in 2010 so it is probably no longer maintained.

That's why we have to add the missing field ourselves.

Gentoo-Bug: https://bugs.gentoo.org/583882
Package-Manager: Portage-2.3.3, Repoman-2.3.1
@maciejsszmigiero
Copy link
Contributor Author

@kentfredric:

What's the point of the eutils inherit?

That was a leftover from an older ebuild version, which used "epatch" to apply this patch.
But you are right - EAPI 6 "PATCHES" variable don't need "eutils" inherit so removed it now.

@kentfredric
Copy link
Contributor

EAPI5 didn't need it for perl-module.eclass either :)

perl-module_src_prepare() {
        debug-print-function $FUNCNAME "$@"

        if [[ ${EAPI:-0} == 5 ]] ; then
                [[ ${PATCHES[@]} ]] && epatch "${PATCHES[@]}"
                debug-print "$FUNCNAME: applying user patches"
                epatch_user
        else
                default
        fi

But otherwise this looks good to me.

@gentoo-repo-qa-bot
Copy link
Collaborator

😞 The QA check for this pull request has found the following issues:

Issues inherited from Gentoo (may be modified by PR):
https://qa-reports.gentoo.org/output/gentoo-ci/f32aad6aa/output.html#games-board/gnuchess-book

@kentfredric
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
assigned PR successfully assigned to the package maintainer(s).
Projects
None yet
3 participants