New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app-admin/logstash-bin: bump to 5.5.3/5.6.1, drop old #5665
Conversation
|
Pull Request assignment Areas affected: ebuilds app-admin/logstash-bin: @hydrapolic, |
|
Nice, thanks! Couple of quick questions (without testing these cases out yet):
I guess it might be enough to just notify the users on upgrade, to make sure they can check if they need clean up and/or move data properly (on first install these doesn't seem to matter). |
But I'm also fine by adding a note for those that are upgrading. |
|
I believe the data directory mostly (only?) used for the persistent queue, which might be important during non-normal operation (e.g. abnormal pipeline termination, or similar), that might happen after moving the pidfile, and killing the process forcefully (see Shutting Down Logstash). Other use case for the persistent queues is to provide buffering during bursts and/or when the delivery is slower than the incoming amount of logs. So normally there's no data, but if there is something, then it is most probably important (and need to be picked up by the new process). I also think Gentoo users who are using persistent queues are also able to shut down the old instance properly, and check if there's any data to be moved. Though after thinking a lot about this, I'd say the ebuild should at least remind the user about these, as I'm afraid it can lead to a potential data loss. Something along the lines of: Maybe I'm just overly cautious :) |
|
Yeah, that sounds reasonable @ferki. I'll add it to the PR and bump to 5.5.3 instead. Thanks! |
801005e
to
9df19ef
Compare
|
@hydrapolic: for me, it looks working correctly and as intended |
|
Personally I would remove |
|
Yes that's a good point, I'll make it so. |
Package-Manager: Portage-2.3.10, Repoman-2.3.3
Package-Manager: Portage-2.3.10, Repoman-2.3.3
9df19ef
to
969be73
Compare
|
|
|
Pulled, thank you! |
No description provided.