Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sci-electronics/systemc: Bump version to 2.3.2 #6211

Closed
wants to merge 1 commit into from
Closed

sci-electronics/systemc: Bump version to 2.3.2 #6211

wants to merge 1 commit into from

Conversation

sonOfRa
Copy link
Contributor

@sonOfRa sonOfRa commented Nov 17, 2017

This version of systemc attempts to do its own compile-time detection of
what C++ standard the current C++ compiler is capable of. Overwriting
this is possible by setting certain macros at compile-time. Those macros
are toggled by the cxx03,11,14,17 USE flags.

Package-Manager: Portage-2.3.14, Repoman-2.3.6

@sonOfRa
Copy link
Contributor Author

sonOfRa commented Nov 17, 2017

Note: I'm not exactly sure if this is the correct way to solve this problem. Currently, when trying to link programs against the systemc library, they must be compiled with the same -std=... option that systemc was compiled with.

@gentoo-repo-qa-bot
Copy link
Collaborator

Pull Request assignment

Areas affected: ebuilds
Packages affected: sci-electronics/systemc

sci-electronics/systemc: @gentoo/sci-electronics

No bug reference found in commit messages. If you would like to reference bugs in the pull request, please make sure to use GLEP 66 tags in the commit message.

If there is no bug open for this pull request, please open one. Otherwise, please link it to the commit messages as noted above.

@gentoo-repo-qa-bot gentoo-repo-qa-bot added assigned PR successfully assigned to the package maintainer(s). no bug found No Bug/Closes found in the commits. labels Nov 17, 2017
SoapGentoo
SoapGentoo suggested changes Nov 17, 2017
View reviewed changes
sci-electronics/systemc/systemc-2.3.2.ebuild Outdated

RESTRICT="test"

AUTOTOOLS_IN_SOURCE_BUILD=1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not in use anymore

sci-electronics/systemc/systemc-2.3.2.ebuild Outdated
S="${WORKDIR}/${MY_P}"

src_configure() {
if use cxx17 ; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not fly. Use the sanest subset (imo C++14) and settle for that, anything else will drive me and QA insane.

@SoapGentoo SoapGentoo added do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. work in progress The PR is not yet ready to be merged. labels Nov 17, 2017
@sonOfRa
sci-electronics/systemc: Bump version to 2.3.2
74b6ba2 
This version of systemc attempts to do its own compile-time detection of
what C++ standard the current compiler is capable of. This behaviour is
suppressed, and the C++14 standard is enforced. If a user sets custom
CXXFLAGS via package.env, those settings are honored, and a warning is
given in postinst

Bug: https://bugs.gentoo.org/637952
Package-Manager: Portage-2.3.14, Repoman-2.3.6
SoapGentoo
SoapGentoo suggested changes Nov 28, 2017
View reviewed changes
sci-electronics/systemc/systemc-2.3.2.ebuild
# Copyright 1999-2017 Gentoo Foundation
# Distributed under the terms of the GNU General Public License v2

EAPI=5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why EAPI 5?

sci-electronics/systemc/systemc-2.3.2.ebuild

EAPI=5

inherit eutils toolchain-funcs flag-o-matic
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you need eutils?

sci-electronics/systemc/systemc-2.3.2.ebuild
SLOT="0"
LICENSE="Apache-2.0"
IUSE="doc static-libs"
KEYWORDS="~amd64 ~x86"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

LICENSE="Apache-2.0"
SLOT="0"
KEYWORDS="~amd64 ~x86"
IUSE="doc static-libs"

yes, idiomatic order is important

sci-electronics/systemc/systemc-2.3.2.ebuild

S="${WORKDIR}/${MY_P}"

CUSTOM_CXX_STD="$(get-flag -std)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dont define this in global scope

sci-electronics/systemc/systemc-2.3.2.ebuild
if [ -z "${CUSTOM_CXX_STD}" ]; then
append-cxxflags -std=c++14
append-cxxflags -DSC_CPLUSPLUS=201402L
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

if ! is-flagq '-std=*'; then
	append-cxxflags -std=c++14
	append-cxxflags -DSC_CPLUSPLUS=201402L
else
	ewarn "You set a custom C++ standard for this ebuild. This is unsupported and may introduce breakage."
	ewarn "Consult the SystemC manual for which Macro definitions you have to set for this to work."
fi

then get rid of CUSTOM_CXX_STD

sci-electronics/systemc/systemc-2.3.2.ebuild
}

src_install() {
dodoc AUTHORS ChangeLog INSTALL NEWS README RELEASENOTES
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

einstalldocs instead because

  1. we don't want INSTALL
  2. the defaults should cover it (consider whether you really need RELEASENOTES, if you do, do a separate dodoc RELEASENOTES instead)

sci-electronics/systemc/systemc-2.3.2.ebuild
src_install() {
dodoc AUTHORS ChangeLog INSTALL NEWS README RELEASENOTES
rm docs/Makefile* || die
use doc && dodoc -r docs/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use doc && dodoc -r docs/.
(avoid unnecessary globbing)

sci-electronics/systemc/systemc-2.3.2.ebuild
dodoc AUTHORS ChangeLog INSTALL NEWS README RELEASENOTES
rm docs/Makefile* || die
use doc && dodoc -r docs/*
cd src
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing || die

sci-electronics/systemc/systemc-2.3.2.ebuild
elog " ./configure"
elog " cd examples"
elog " make check"
if [ -n "${CUSTOM_CXX_STD}" ]; then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with the previous changes, chuck this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please you make get next version of ebuild:
http://pastebin.calculate-linux.ru/en/show/32941

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping

@FuzzyGophers
Copy link
Contributor

@sonOfRa do you still intend to work on this PR?

@FuzzyGophers
Copy link
Contributor

No activity in 45+ days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktrace ktrace ktrace left review comments

@SoapGentoo SoapGentoo SoapGentoo requested changes

Assignees
No one assigned
Labels
assigned PR successfully assigned to the package maintainer(s). do not merge Please DO NOT MERGE this PR. It will not be assigned but it will be scanned by CI. no bug found No Bug/Closes found in the commits. work in progress The PR is not yet ready to be merged.
Projects
None yet
Milestone
No milestone
5 participants
@sonOfRa @gentoo-repo-qa-bot @FuzzyGophers @SoapGentoo @ktrace