qt5-build.eclass, qt4-build-multilib.eclass: Switch qtchooser to qt5-default #7255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pesa
suggested changes
Feb 22, 2018
eclass/qt4-build-multilib.eclass
Outdated
| @@ -479,7 +479,6 @@ qt4_multilib_src_install() { | |||
| dosym qt4-"${CHOST}".conf /etc/xdg/qtchooser/4.conf | |||
| dosym qt4-"${CHOST}".conf /etc/xdg/qtchooser/qt4.conf | |||
| # TODO bug 522646: write an eselect module to manage default.conf | |||
There was a problem hiding this comment.
move this comment to the qt5 eclass
|
I'm not sure why there should be a blocker in |
|
If only qtcore:4 is updated then users are left without a |
Pesa
approved these changes
Feb 22, 2018
Follow-up to a888955 and 5d7ff88 Bug: https://bugs.gentoo.org/564622 Package-Manager: Portage-2.3.24, Repoman-2.3.6
|
Pull request CI report Report generated at: 2018-02-22 22:19 UTC No issues found |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.