Support HTTP when pushing with --insecure-registry #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kflansburg
changed the title
AkihiroSuda
requested changes
Mar 8, 2021
SebastiaanPasterkamp
added a commit
to SebastiaanPasterkamp/drone-genuinetools-img
that referenced
this pull request
Jun 11, 2021
Manually apply a (modified) genuinetools/img#329 Add change to Dockerfile to turn image into drone plugin
SebastiaanPasterkamp
added a commit
to SebastiaanPasterkamp/drone-genuinetools-img
that referenced
this pull request
Jun 11, 2021
* Manually apply a (modified) genuinetools/img#329 * Add change to Dockerfile to turn image into drone plugin
SebastiaanPasterkamp
added a commit
to SebastiaanPasterkamp/drone-genuinetools-img
that referenced
this pull request
Jun 11, 2021
* Manually apply a (modified) genuinetools/img#329 * Add change to Dockerfile to turn image into drone plugin
SebastiaanPasterkamp
added a commit
to SebastiaanPasterkamp/drone-genuinetools-img
that referenced
this pull request
Jun 11, 2021
* Manually apply a (modified) genuinetools/img#329 * Add change to Dockerfile to turn image into drone plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Closes #297 by cherry picking this commit from @aler9.
My test case was being able to push to a stock Docker registry container with no configurations set (and thus using HTTP).
I suspect that this may break the use case of pushing to an HTTPS endpoint whilst ignoring a custom CA using
--insecure-registry. If that is a requirement then we may need to introduce an argument to specify protocol.