New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displays transformed geospatial metadata in the HTML #555

Merged
merged 1 commit into from Aug 10, 2017

Conversation

Projects
None yet
4 participants
@jrgriffiniii
Collaborator

jrgriffiniii commented Jul 27, 2017

Resolves #173, #380, and #559 by addressing the following:

  • Implements Classes for the transformation of geospatial metadata into the HTML
  • Provides XSL Stylesheets for the transform

Still being addressed:

  • Migrating the XSL Stylesheet customizations into GeoCombine (Postponed: OpenGeoMetadata/GeoCombine#18 (comment))
  • Enabling downloads for the XML metadata
  • Styling for the metadata interface
  • Refactoring the BaseTransformer Class
  • Improve the inline documentation for BaseTransformer, FcgdTransformer, and Iso19139Transformer
  • Extend the Modal for missing metadata resources (e. g. 404 responses)
@mejackreed

This comment has been minimized.

Show comment
Hide comment
@mejackreed

mejackreed Jul 28, 2017

Member

Some of these transforms may be already implemented in the GeoCombine gem

Would it be possible to use those api's already developed and include these as a gem? (instead of maintaining both separately)

Member

mejackreed commented Jul 28, 2017

Some of these transforms may be already implemented in the GeoCombine gem

Would it be possible to use those api's already developed and include these as a gem? (instead of maintaining both separately)

@jrgriffiniii

This comment has been minimized.

Show comment
Hide comment
@jrgriffiniii

jrgriffiniii Aug 1, 2017

Collaborator

Would it be possible to use those api's already developed and include these as a gem? (instead of maintaining both separately)

@mejackreed thank you very much for this review and guidance. I shall proceed by focusing next upon GeoCombine, and trying to migrate these XSL Stylesheets upstream.

Collaborator

jrgriffiniii commented Aug 1, 2017

Would it be possible to use those api's already developed and include these as a gem? (instead of maintaining both separately)

@mejackreed thank you very much for this review and guidance. I shall proceed by focusing next upon GeoCombine, and trying to migrate these XSL Stylesheets upstream.

@jrgriffiniii jrgriffiniii referenced this pull request Aug 1, 2017

Merged

Moved closing dl tag #63

@jrgriffiniii jrgriffiniii changed the title from [WIP] Displays transformed geospatial metadata in the HTML to Displays transformed geospatial metadata in the HTML Aug 2, 2017

@jrgriffiniii jrgriffiniii changed the title from Displays transformed geospatial metadata in the HTML to [WIP] Displays transformed geospatial metadata in the HTML Aug 2, 2017

@jrgriffiniii jrgriffiniii changed the title from [WIP] Displays transformed geospatial metadata in the HTML to Displays transformed geospatial metadata in the HTML Aug 2, 2017

@jrgriffiniii

This comment has been minimized.

Show comment
Hide comment
@jrgriffiniii

jrgriffiniii Aug 3, 2017

Collaborator

@mejackreed I've refactored the jQuery functionality a bit further: https://github.com/geoblacklight/geoblacklight/pull/555/files#diff-10a899d9a4b773ff0cd7620459ec56d1
...as well as resolved a styling issue for the metadata Modal for narrower viewports, and removed CodeRay.

Collaborator

jrgriffiniii commented Aug 3, 2017

@mejackreed I've refactored the jQuery functionality a bit further: https://github.com/geoblacklight/geoblacklight/pull/555/files#diff-10a899d9a4b773ff0cd7620459ec56d1
...as well as resolved a styling issue for the metadata Modal for narrower viewports, and removed CodeRay.

@jrgriffiniii jrgriffiniii added this to the Sprint - Summer 2017 milestone Aug 3, 2017

@jrgriffiniii jrgriffiniii changed the title from Displays transformed geospatial metadata in the HTML to [WIP] Displays transformed geospatial metadata in the HTML Aug 4, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 5, 2017

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 6, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling e4f7a5b on issues-173-jrgriffiniii-view-download-metadata into a661200 on master.

coveralls commented Aug 6, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling e4f7a5b on issues-173-jrgriffiniii-view-download-metadata into a661200 on master.

@jrgriffiniii jrgriffiniii changed the title from [WIP] Displays transformed geospatial metadata in the HTML to Displays transformed geospatial metadata in the HTML Aug 6, 2017

@geoblacklight geoblacklight deleted a comment from coveralls Aug 6, 2017

@eliotjordan

Great work @jrgriffiniii ! This is thoughtful and well-constructed. I'm definitely in favor of adding GeoCombine as a dependency. As GeoCombine matures, I think we'll find more uses for it within core GeoBlacklight. After addressing / chatting about the comments I left in the code, I'm a big 👍.

Show outdated Hide outdated lib/geoblacklight/references.rb Outdated
Show outdated Hide outdated spec/helpers/geoblacklight_helper_spec.rb Outdated
Show outdated Hide outdated spec/lib/geoblacklight/metadata_transformer/fgdc_spec.rb Outdated
}
.modal-body {
overflow-y: scroll;

This comment has been minimized.

@eliotjordan

eliotjordan Aug 9, 2017

Member

What do you think about constraining the body height so that that the entire modal fits on the screen? It would be nice to see that download is an option without scrolling to the bottom of the page. Here's what it looks like when you style modal-body with height: calc(100vh - 190px):
screenshot 2017-08-09 00 06 44

@eliotjordan

eliotjordan Aug 9, 2017

Member

What do you think about constraining the body height so that that the entire modal fits on the screen? It would be nice to see that download is an option without scrolling to the bottom of the page. Here's what it looks like when you style modal-body with height: calc(100vh - 190px):
screenshot 2017-08-09 00 06 44

@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling 849c803 on issues-173-jrgriffiniii-view-download-metadata into 354e784 on master.

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling 849c803 on issues-173-jrgriffiniii-view-download-metadata into 354e784 on master.

@jrgriffiniii

This comment has been minimized.

Show comment
Hide comment
@jrgriffiniii

jrgriffiniii Aug 10, 2017

Collaborator

Thank you very much for reviewing this @eliotjordan , I believe that these improvements have been addressed.

Collaborator

jrgriffiniii commented Aug 10, 2017

Thank you very much for reviewing this @eliotjordan , I believe that these improvements have been addressed.

Resolves #173 Implements Classes for the transformation of geospatial…
… metadata into the HTML; Integrates GeoCombine for the transform and uses Bootstrap Modal dialogs for the content

Cleaning styling issues and improving upon the FGDC XSL Stylesheet

Resolving an error for the MetadataTransformer test suite; Addressing the structure of the HTML for section "Spatial Reference Information" section of the FGDC XSL Stylesheet

Correcting the structure of the HTML for the "Distribution Information" and "Metadata Reference Information" sections within the FGDC XSLT

Further resolving issues within the "Identification Information" section of the ISO19139 metadata HTML

Repairing the test suites for BaseTransformer, ISO19139Transformer, and FgdcTransformer

Addressing styling errors and adding the ISO XSL Stylesheet

Removing the XSL import for Bootstrap-specific templates; Adjusting the feature spec. for the metadata tool interface for the updated View template structure

Introducing styling for the metadata modal dialog; Providing jQuery functionality in order to permit the direct download of geospatial metadata; Refactoring the View for the metadata modal

Modifying the metadata upload functionality; Improving the feature test suites

Extending the width of the modal dialog; Ensuring that the Bootstrap accordion widget updates the toggle Glyphicons

Adding GeoCombine as a dependency; Ensuring that XSL transforms are performed using GeoCombine functionality and XSL Stylesheets

Updating the waiting time for the "Download layer" feature test suite

Updating the metadata modal styling in response to the integration of the GeoCombine XSLs

Improving upon the documentation within the MetadataTransformer Module (and Classes) and adding some comments for the dialog SCSS

Removing the deprecated XSLs

Removing the transformed FGDC HTML fixture

Refactoring JavaScript functionality for the metadata dialog download button into the Class GeoBlacklight.MetadataDownloadButton; Removing the unused "equivalent-xml" Gem dependency

Resolving a styling issue for the metadata Modal dialog at restricted viewport widths; Improving upon the test suite for the GeoBlacklight.MetadataDownloadButton

Removing CodeRay as a Gem dependency (and the associated styling)

Removing a newline in _geoblacklight.scss

Renaming the file for GeoBlacklight.MetadataDownloadButton

Refactoring the Bootstrap Modal dialog Views; Restructuring the metadata transformation and metadata Classes; Reimplementing dialog metadata UI components using Bootstrap nav pill Tabs

Cleaning styling issues and removing the "empty?" alias for Geoblacklight::Metadata::Base

Resolving issues for the MetadataTransformer::Fgdc fixture and test suite; Resolving issues for the GeoBlacklight.MetadataDownloadButton functional test suite

Increasing the test coverage for Geoblacklight::Metadata, Geoblacklight::Metadata::Base, GeoblacklightHelper, and Geoblacklight::References

Cleaning inline comments

Improving upon the name used for Geoblacklight::Reference#shown_refs (updating this to #shown_metadata_refs); Ensuring that the height of the metadata dialog Modal is responsive
@coveralls

This comment has been minimized.

Show comment
Hide comment
@coveralls

coveralls Aug 10, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling 1324913 on issues-173-jrgriffiniii-view-download-metadata into 354e784 on master.

coveralls commented Aug 10, 2017

Coverage Status

Coverage increased (+0.1%) to 95.706% when pulling 1324913 on issues-173-jrgriffiniii-view-download-metadata into 354e784 on master.

@jrgriffiniii jrgriffiniii merged commit 2937cc9 into master Aug 10, 2017

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.1%) to 95.706%
Details

@jrgriffiniii jrgriffiniii deleted the issues-173-jrgriffiniii-view-download-metadata branch Aug 10, 2017

@jrgriffiniii jrgriffiniii referenced this pull request Aug 23, 2017

Closed

Fix metadata display functionality #260

1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment