Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix geocam export on iPad 1 #2

Merged
merged 1 commit into from Dec 18, 2012

Conversation

Projects
None yet
2 participants
Contributor

rburhum commented Dec 18, 2012

This fixes issue #1

Thanks for hacking on MapFasten!

A couple of comments.

  1. simple-view.html is deprecated. Does it actually still work? We've replaced it with a UI that uses client-side MVC (backbone) to improve the user experience, and that's where the new UI features will show up. All the action these days is in the not-very-creatively-named backbone.html

  2. The new UI depends on underscore.js, so we've been using underscore's _.bind() function for this purpose. It uses the browser's native function.bind() if available, and its own implementation otherwise. I'd rather not have two different .bind() implementations in the code base, so can you check to see if the underscore version works on iOS?

Cheers,
Ted

Hi Ted. The I realize the main application uses backbone. This file is the one that is used to render the "view.html" provided in the standalone tar.gz file that gets generated during an "export". For example, go here: http://mapfasten.appspot.com/b/#overlay/92/export

You will notice that the view.html is not correct, but will render OK. If you try it on an iPad 1, it will not work. The view.html is a minimalistic html file that only relies on Google Maps (doesn't have backbone nor underscore.js). This fix continues with that philosophy and only adds a custom bind when the underlying web renderer (in this case Webkit on iOS 5.1.1) doesn't have it.

Also, FYI, I have this other pull request geocam/geocamUtilWeb#2

Ah, yes. My mistake. I had it confused with overlay-view.html, which we've already removed.

deleted added a commit that referenced this pull request Dec 18, 2012

Merge pull request #2 from GGSN/master
Fix geocam export on iPad 1
(function.bind() fix for browsers that don't have ECMA5 yet)

@deleted deleted merged commit ee58506 into geocam:master Dec 18, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment