Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script to clip an existing geojson based in an OSM relation ID #7

Merged
merged 1 commit into from Dec 25, 2019

Conversation

@jsanz
Copy link
Contributor

jsanz commented Dec 12, 2019

This script is inteded to work after the first step script to remove from that step square layer those features that are not contained by the polygon defined by the relation identifier in OSM for the city.

The script accepts just a city name and an OSM identifier.

@jsanz

This comment has been minimized.

Copy link
Contributor Author

jsanz commented Dec 12, 2019

@jessisena this is still a work in progress but you can already test the script. I want also to update the documentation. Let me know if apart from that there's anything else I should take care of.

@jessisena

This comment has been minimized.

Copy link
Collaborator

jessisena commented Dec 16, 2019

@jessisena this is still a work in progress but you can already test the script. I want also to update the documentation. Let me know if apart from that there's anything else I should take care of.

@jsanz it looks good 👍 But just tell me when is completely finished, because it will imply some changes in the current process (in order to be able to use it).

Thanks!

@jsanz

This comment has been minimized.

Copy link
Contributor Author

jsanz commented Dec 17, 2019

@jessisena before review I want to explore the idea of integrating this into the first step logic so instead of first clip an area and then afterward a polygon, just pass one or the other option to the Tile Reduce logic. I'll try to find some time this weekend 💪

@jessisena jessisena marked this pull request as ready for review Dec 25, 2019
@jessisena

This comment has been minimized.

Copy link
Collaborator

jessisena commented Dec 25, 2019

As for now the functionality is completely isolated, no problem about merging it in the master branch.

@jessisena jessisena merged commit 3142283 into geochicasosm:master Dec 25, 2019
@jsanz jsanz deleted the jsanz:clip-osm-relation-polygon branch Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.