Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an HTTP client to be injected via the constructor of providers #274

Merged
merged 1 commit into from Jan 8, 2020

Conversation

@nicolas-grekas
Copy link
Contributor

nicolas-grekas commented Jan 7, 2020

This allows leveraging the new HttplugClient of the Symfony HttpClient when possible, instead of having to use static discovery when not using HttplugBundle.

@norkunas

This comment has been minimized.

Copy link
Member

norkunas commented Jan 8, 2020

@nicolas-grekas tests are failing with autowiring

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:inject-http-client branch 4 times, most recently from 8b5fc61 to d3d4e2a Jan 8, 2020
@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:inject-http-client branch from d3d4e2a to 26e7d33 Jan 8, 2020
@nicolas-grekas

This comment has been minimized.

Copy link
Contributor Author

nicolas-grekas commented Jan 8, 2020

Tests fixed.

@norkunas norkunas merged commit a79f50a into geocoder-php:master Jan 8, 2020
3 checks passed
3 checks passed
PHPStan
Details
PHP-CS-Fixer
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@norkunas

This comment has been minimized.

Copy link
Member

norkunas commented Jan 8, 2020

Thank you @nicolas-grekas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.