Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Algolia places provider is not working anymore #960

Closed
jkobus opened this issue May 20, 2019 · 7 comments

Comments

Projects
None yet
3 participants
@jkobus
Copy link

commented May 20, 2019

Algolia Places response structure changed, therefore the provider is not working anymore.
Algolia added localized names (client expects value but it instead sees another array):
https://community.algolia.com/places/api-clients.html#json-answer

Algolia is also missing its factory.

@jkobus jkobus changed the title Algolia places is not working anymore Algolia places provider is not working anymore May 20, 2019

@jbelien

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Thanks for the notice @jkobus !

Would you have some time to provide a PR ?

@jkobus

This comment has been minimized.

Copy link
Author

commented May 21, 2019

In a spare time, sure. Todo:

  • add factory (should it be in the main repository?)
  • fix bug in provider
  • add or update documentation
@jbelien

This comment has been minimized.

Copy link
Member

commented May 21, 2019

Ping @Fabex the original author of Algolia Places provider !

@atymic

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Happy to jump on this when I have some time if required :)

@atymic

This comment has been minimized.

Copy link
Contributor

commented Jun 24, 2019

I've opened a PR.
@jkobus what do you mean by adding a factory?

@jbelien jbelien closed this in #970 Jun 24, 2019

@jbelien

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@jkobus

This comment has been minimized.

Copy link
Author

commented Jun 24, 2019

@atymic factory is for the symfony bundle (https://github.com/geocoder-php/BazingaGeocoderBundle/blob/master/Resources/doc/index.md#usage), although it is possible to use the geocoder provider without it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.