Skip to content

Add geo array dumper #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
norkunas wants to merge 34 commits into from
Closed

Add geo array dumper #517

norkunas wants to merge 34 commits into from

Conversation

@norkunas
Copy link
Member

@norkunas norkunas commented Jul 26, 2016

@drupol
Copy link

drupol commented Dec 10, 2016

I like that !

Nyholm
Nyholm requested changes Dec 22, 2016
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response time. Could you rebase this PR and I'll be happy to merge

src/Geocoder/Dumper/GeoArray.php
/**
* {@inheritDoc}
*/
public function dump(Address $address)
Copy link
Member

@Nyholm Nyholm Dec 22, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be Location

Nyholm and others added 26 commits December 22, 2016 18:04
@Nyholm @norkunas
Implement Httplug (geocoder-php#512)
7e86f60 
* Implement httplug

* Fix tests and remove .puli from repo

* Remove php 5.4

* Updated dependencies

* Doc update and use latest discovery

* Make sure we using phpuinit 4

* Using discovery 1.0

* Fixed doc block alignment

* Use PSR7 implementations instead of mocks
@Nyholm @norkunas
Added example how to use cache
87431e6
@Nyholm @norkunas
Minor
7b8c562
@Nyholm @norkunas
Moved cache to a cookbook
5efd30d
@Nyholm @norkunas
minor
c4b6c4b
@Nyholm @norkunas
Added info how to configure the HTTP client
6b200e3
@Nyholm @norkunas
Added full namespace to exceptions (geocoder-php#528)
7bddfcb
@vicchi @norkunas
Fix bug where cached unit test responses aren't serialised
6de7bc9
@vicchi @norkunas
Add Mapzen provider support
182830c
@unkind @norkunas
Finalize the providers (geocoder-php#540)
0775734
@Nyholm @norkunas
Creating interfaces to be more SOLID
3317b5a
@Nyholm @norkunas
Removed interfaces for value objects
35fccac
@Nyholm @norkunas
Removed interfaces for value objects
6f8a937
@Nyholm @norkunas
Updated "use" statements
3a30b00
@Nyholm @norkunas
bugfix
f4bfa7e
@Nyholm @norkunas
Removed unused "use" statements
6674c44
@Nyholm @norkunas
bugfix
d77ba21
@Nyholm @norkunas
Added comment
5d491fa
@Nyholm @norkunas
Added test for empty address
2c9e29f
@willdurand @norkunas
Update links for documentation (geocoder-php#542)
da88d48
@Nyholm @norkunas
Changed name from Position to Location
8fd99d6
@Nyholm @norkunas
Make constructor arguments optional
fc5e82b
@Nyholm @norkunas
We are defined even if (lat, lang) = (0, 0)
3fcd48c
@Nyholm @norkunas
Updated variable names
bd3f942
@Nyholm @norkunas
minor
ab073ac
@Nyholm @norkunas
Removed some deprecated functions
83a45db
@Nyholm
Copy link
Member

Nyholm commented Dec 22, 2016 •
edited
Loading

I think you did merge instead of rebase..

To recover:

git checkout master
git reset --hard origin/master
git pull
git checkout -b array-dumper-2
git cherry-pick 8c651f9
git push -u norkunas array-dumper-2

(You could aslo force push to this branch.)

@norkunas norkunas mentioned this pull request Dec 23, 2016
Merged
@norkunas norkunas closed this Dec 23, 2016
@norkunas norkunas deleted the array-dumper branch December 23, 2016 06:38
@norkunas
Copy link
Member Author

norkunas commented Dec 23, 2016

Sorry, fixed in new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Nyholm Nyholm Nyholm requested changes

Assignees

No one assigned

Labels

need rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@norkunas @drupol @Nyholm @vicchi @unkind @willdurand @arubacao