Add level to Address::toArray function

[AntoineLemaire]

Fix #516

[willdurand]

Well, the index already provides the level. Why not using it?

[Nyholm]

Oh, I did also miss that. Sorry-

[AntoineLemaire]

It's what I explained in my issue. Why toArray function result could not be used directly by fromArray function without modifications of this array?

[willdurand]

Ah. Did not read the whole issue sorry... So, does it work better now? It is a simple addition, so if you add a test case for this, then it's good to me!

[AntoineLemaire]

How do you see that? Add testToArray() to all Provider tests files? Or choose a random provider in AddressFactoryTest and test toArray, fromArray and assertSame on init address and result address?

[willdurand]

Is there any test class for the Address class?

[AntoineLemaire]

No, only AddressFactory

[willdurand]

Then, maybe you could create this test class

[willdurand]

Can you also provide a test for this toArray/fromArray thing please?

[AntoineLemaire]

Done & commits squash

[willdurand]

Looks good to me!

[vicchi]

+1 LGTM

[Nyholm]

Hey @AntoineLemaire.

Sorry for the delay with this PR. If you solve the merge conflicts I'll be happy to merge

[Nyholm]

Fixed by #622

[AntoineLemaire]

Oh sorry, I missed that! Thanks for merged it 👍