Skip to content

Conversation

@cweiske
Copy link

@cweiske cweiske commented Nov 24, 2016

They can occur when a free but limited key is used and the number
no more requests are allowed.

They can occur when a free but limited key is used and the number
no more requests are allowed.
@willdurand
Copy link
Member

Ideally, we should cover this change with a test case.

@Nyholm
Copy link
Member

Nyholm commented May 26, 2017

I will close this PR.

403 means forbidden, Authentication will not help.
401 means that you are unauthenticated.

Reference: https://msdn.microsoft.com/en-us/library/ff701703.aspx

Recent changes in master do already cover 401 erros.

@Nyholm Nyholm closed this May 26, 2017
@cweiske
Copy link
Author

cweiske commented May 27, 2017

@Nyholm - we saw the 403 status code in production. Our code silently failed because geocoder-php did not expose this error condition.

Catching 401 errors does not help in the circumstances described in the initial PR comment.

If you close this PR without handling 403 errors in any way, other people will fall in the same trap.

@Nyholm
Copy link
Member

Nyholm commented May 27, 2017

Thank you.
We are handling them. See https://github.com/geocoder-php/Geocoder/blob/master/src/Common/Provider/AbstractHttpProvider.php#L61

But we are not using there UnauthorizedException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants