New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Geoportail.lu geocoder #898

Merged
merged 1 commit into from Nov 23, 2018

Conversation

Projects
None yet
2 participants
@frantzmiccoli
Contributor

frantzmiccoli commented Nov 5, 2018

No description provided.

@jbelien jbelien self-requested a review Nov 6, 2018

@jbelien jbelien self-assigned this Nov 6, 2018

@jbelien jbelien added the provider label Nov 6, 2018

@jbelien

This comment has been minimized.

Member

jbelien commented Nov 6, 2018

Hello @frantzmiccoli ,

Thanks a lot for your contribution ! 👍

Before adding your provider to our list of third-party providers, could you use Geocoder\IntegrationTest\BaseTestCase in your test ?
You can check the tests of any of our providers to see how it works.

Thanks !

EDIT: Geocoder\IntegrationTest\BaseTestCase is provided by geocoder-php/provider-integration-tests package.

@jbelien jbelien removed their request for review Nov 6, 2018

@frantzmiccoli

This comment has been minimized.

Contributor

frantzmiccoli commented Nov 6, 2018

Hi!

I will try to do this in the next days.

Thanks,

@frantzmiccoli

This comment has been minimized.

Contributor

frantzmiccoli commented Nov 20, 2018

Hi @jbelien

It took me a bit more time to find time but it is done ;)

Thanks,

@jbelien

This comment has been minimized.

Member

jbelien commented Nov 20, 2018

Awesome ! Thanks a lot :)
I'll have a look ASAP !

@jbelien

This comment has been minimized.

Member

jbelien commented Nov 20, 2018

@frantzmiccoli

This comment has been minimized.

Contributor

frantzmiccoli commented Nov 23, 2018

Accepted ;)

@jbelien jbelien merged commit be36789 into geocoder-php:master Nov 23, 2018

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment