Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add geocode-earth provider #962

Merged
merged 4 commits into from Jun 14, 2019

Conversation

@atymic
Copy link
Member

commented May 30, 2019

This adds a new provider for https://geocode.earth/

They don't seem to have any public API docs, nor a free version of the API available without signup.
I've flicked them an email asking for a test key + API docs.

For the moment all the tests are failing due to this, i'll resolve this once I get the test key

I'm also not sure of the exact process for creating a new provider, so let me know what needs to be fixed

Resolves #808

Thanks 馃槃

feat: add geocode-earth provider
This adds a new provider for https://geocode.earth/

Resolves #808

@atymic atymic force-pushed the atymic:geocode-earth branch from 1277c8c to fc55858 May 30, 2019

@jbelien jbelien added the provider label May 30, 2019

@jbelien

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Thanks a lot for this ! 馃帀

Could you make sure it passes all the tests ?
I just had a quick look and I think there is just the .cached_response files missing in your PR.

@atymic

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

Could you make sure it passes all the tests ?
I just had a quick look and I think there is just the .cached_response files missing in your PR.

Just waiting for them to drop me some test API keys :)

atymic added some commits May 30, 2019

@atymic

This comment has been minimized.

Copy link
Member Author

commented May 30, 2019

The tests seem to be failing on php < 7.1, maybe due to serialisation changes?
Not sure how to best resolve this.

@jbelien

This comment has been minimized.

Copy link
Member

commented May 31, 2019

To fix the failed test, add <server name="GEOCODE_EARTH_API_KEY" value="YOUR_GEOCODE_EARTH_API_KEY" /> also in the main phpunit.xml.dist.

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 1, 2019

Done, thanks @jbelien :)

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

Is there anything else required for this PR?

@jbelien

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Sorry, didn't have time to properly have a look at it yet!
I'll do that ASAP :)

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 13, 2019

No worries, sorry to bug 馃槃

@jbelien jbelien merged commit abbe456 into geocoder-php:master Jun 14, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jbelien

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

Thanks a lot for the PR @atymic !

@Nyholm We have a new provider 馃帀 Could you create the new sub-package ? Thanks.

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 14, 2019

No worries 馃槃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.