Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate geoips provider #972

Merged
merged 3 commits into from Jul 15, 2019

Conversation

@atymic
Copy link
Member

commented Jun 24, 2019

  • adds @deprecated annotations to the class & constructor (which will warn people using IDEs)
  • Updates the readme and changelog to communicate the deprecation
  • Removes it from the main readme.

Todo:

  • Mark packagist as abandoned.

Closes #965

atymic added some commits Jun 24, 2019

fix: deprecate geoips provider
- adds `@deprecated` annotations to the class & constructor (which will warn people using IDEs)
- Updates the readme and changelog to communicate the deprecation
- Removes it from the main readme.
@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 24, 2019

I've also added some documentation to the repo for how to deprecate providers. Let me know if you have any thoughts/suggestions.

@jbelien jbelien requested a review from Nyholm Jun 25, 2019

@Nyholm
Copy link
Member

left a comment

Thank you for this PR.

src/Provider/GeoIPs/GeoIPs.php Outdated Show resolved Hide resolved
@Nyholm

Nyholm approved these changes Jun 25, 2019

Copy link
Member

left a comment

Thank you

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jun 25, 2019

No worries 😄

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

@jbelien sorry to bother, but is there anything else that needs doing on this?

@Nyholm

Nyholm approved these changes Jul 9, 2019

@atymic

This comment has been minimized.

Copy link
Member Author

commented Jul 9, 2019

(if you are approving again so I can merge, It doesn't give me the option unfortunately)

@jbelien jbelien merged commit 30ad373 into geocoder-php:master Jul 15, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.