Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix ci geoip conflicts #985

Merged
merged 1 commit into from Jul 23, 2019

Conversation

@atymic
Copy link
Member

commented Jul 22, 2019

This PR adds an extra helper command GEOIP_EXT_REMOVE to remove the geoip extension once the test that requires it has run.

This is needed because there are other tests that require it's not installed.

For more info, see #983

cc @jbelien

Closes #983

@atymic atymic force-pushed the atymic:fix-travis-geoip branch 2 times, most recently from f1d1578 to 442466d Jul 23, 2019

@atymic atymic closed this Jul 23, 2019

@atymic atymic force-pushed the atymic:fix-travis-geoip branch from 442466d to 834b4ba Jul 23, 2019

@atymic atymic reopened this Jul 23, 2019

@atymic atymic force-pushed the atymic:fix-travis-geoip branch from 9030a01 to 3c554cf Jul 23, 2019

@atymic atymic force-pushed the atymic:fix-travis-geoip branch from 3c554cf to 2685766 Jul 23, 2019

@jbelien jbelien merged commit b0e887f into geocoder-php:master Jul 23, 2019

2 checks passed

continuous-integration/styleci/pr The analysis has passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.