From ced6d18e8d0ed918ba8f01fe3ed9a328b82e352f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jonathan=20Beli=C3=ABn?= <jbelien@users.noreply.github.com>
Date: Sun, 16 Jul 2023 16:36:39 +0200
Subject: [PATCH] Add PHPStan in CI (#1193)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* Add PHPStan

* Update php.yml

* Update composer.json

* Fix PHPStan level 0

* Fix PHPStan level 1

* Update phpstan.neon

* Fix PHPStan level 2

* Update composer.json

* Fix PHPStan level 3

* Fix tests

* Fix PHPStan level 4

* Update src/Common/Tests/TimedGeocoderTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/Cache/Tests/ProviderCacheTest.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Provider/GeoIP2/Tests/GeoIP2Test.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Fix PHPStan level 5

* Normalize composer.json

* Rename analyse script

* Update composer.json

* Update IntegrationTest

* Update AlgoliaPlacesTest

* Update composer.json

* Update RequestInterface vs. getParsedResponse()

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Update src/Plugin/PluginProvider.php

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>

* Use PHPStan baseline instead of ignore

See https://phpstan.org/user-guide/baseline

---------

Co-authored-by: Tomas Norkūnas <norkunas.tom@gmail.com>
---
 Tests/ProviderCacheTest.php | 15 +++------------
 1 file changed, 3 insertions(+), 12 deletions(-)

diff --git a/Tests/ProviderCacheTest.php b/Tests/ProviderCacheTest.php
index 9b1c355..cec3f6e 100644
--- a/Tests/ProviderCacheTest.php
+++ b/Tests/ProviderCacheTest.php
@@ -18,6 +18,7 @@
 use Geocoder\Provider\Provider;
 use Geocoder\Query\GeocodeQuery;
 use Geocoder\Query\ReverseQuery;
+use PHPUnit\Framework\MockObject\MockObject;
 use PHPUnit\Framework\TestCase;
 use Psr\SimpleCache\CacheInterface;
 
@@ -27,12 +28,12 @@
 class ProviderCacheTest extends TestCase
 {
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|Provider
+     * @var Provider&MockObject
      */
     private $providerMock;
 
     /**
-     * @var \PHPUnit_Framework_MockObject_MockObject|CacheInterface
+     * @var CacheInterface&MockObject
      */
     private $cacheMock;
 
@@ -60,16 +61,6 @@ public function testName()
         $this->assertEquals('foo (cache)', $providerCache->getName());
     }
 
-    public function testMagicFunction()
-    {
-        $this->providerMock->expects($this->once())
-            ->method('getFoo')
-            ->willReturn('foo');
-
-        $providerCache = new ProviderCache($this->providerMock, $this->cacheMock);
-        $this->assertEquals('foo', $providerCache->getFoo());
-    }
-
     public function testGeocodeMiss()
     {
         $query = GeocodeQuery::create('foo');