Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Fixing the "flipped" status of a record, Removed "excensus" branch notice #31
Conversation
added some commits
Aug 13, 2012
ajturner
added a commit
that referenced
this pull request
Aug 15, 2012
|
|
ajturner |
2500432
|
ajturner
merged commit 2500432
into geocommons:master
Aug 15, 2012
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
theduckylittle commentedAug 13, 2012
Hi Folks,
I found a bug while doing some large geocoding projects regarding the "flipped" status. On some edges this caused a geocode to be placed a far-cry from where it should have been.
The bug is how the gem was handling the return of the "flipped" value from SQLite. Since SQLite is typeless it was returning the string but not evaluating correctly in ruby. I forced a ruby type-cast to integer using "to_i" and then looked for the value to be 1 to be truly flipped.
The other change is removing the notice about the Excensus branch. I'm trying to keep things a bit cleaner and culled the branch. That makes the notice in the README pretty irrelevant.