# Output dynamic topography as point-wise vector #2791

Merged

## Conversation

Projects
None yet
3 participants
Contributor

### gassmoeller commented Jan 30, 2019

 This addresses the dynamic topography part of #2788 and was really simpler than I expected. Even without using interpolated visualization output the effect is nice (side-by-side comparison of the S20RTS cookbook with and without the new output):

Merged

Contributor

### MFraters left a comment

 Looks great Rene! I just have some comments on documentation of the code.
 @@ -44,10 +44,13 @@ namespace aspect */

#### MFraters Feb 28, 2019

Contributor

 @@ -66,8 +69,9 @@ namespace aspect * to.

#### MFraters Feb 28, 2019

Contributor

Same here.

 new Vector(dynamic_topography.cellwise_topography())); auto cell = input_data.template get_cell >(); bool cell_at_top_or_bottom_boundary = false;

#### MFraters Feb 28, 2019

Contributor

Maybe the code could use some more comment to make reading it easier. You could for example put a comment here like: "We are only interested in the faces at the top and bottom of the domain, so we check that here."

#### MFraters Feb 28, 2019

Contributor

And here something like: "This cell is at the top or bottom, now compute the values of the dynamic topography in this cell."
It might be just my personal style, but I like very verbose comments. If you feel it clutters the code too much, feel free to leave it out.

### naliboff reviewed Feb 28, 2019

#### naliboff Feb 28, 2019

Contributor

Might be worth putting a short comment here explaining why one needs to use the temperature quadrature.

### gassmoeller added some commits Jan 30, 2019

``` Output dynamic topography as point-wise vector ```
``` e7fb2c2 ```
``` Address comments ```
``` 9ec9a95 ```

### gassmoellerforce-pushed the gassmoeller:dynamic_topography_point_wise_vector branch from `2365bb8` to `9ec9a95`Mar 1, 2019

Contributor Author

### MFraters merged commit `1e803e0` into geodynamics:master Mar 1, 2019 2 checks passed

#### 2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details