Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VoF: add test for graphical output #2849

Merged
merged 2 commits into from Mar 18, 2019

Conversation

Projects
None yet
2 participants
@tjhei
Copy link
Member

commented Mar 12, 2019

none of the tests trigger graphical output of "volume of fluid values".
Fix this.

@tjhei tjhei force-pushed the tjhei:vof_viz_test branch from 3aaca4d to b6a94e1 Mar 12, 2019

VoF: add test for graphical output
none of the tests trigger graphical output of "volume of fluid values".
Fix this.

@tjhei tjhei force-pushed the tjhei:vof_viz_test branch from b6a94e1 to 838e7a6 Mar 13, 2019

@tjhei

This comment has been minimized.

Copy link
Member Author

commented Mar 13, 2019

test failed crashed before being based on #2848 and passes now. Ready to be merged, I think.

@gassmoeller

This comment has been minimized.

Copy link
Contributor

commented Mar 13, 2019

Yes looks good. I guess it was on purpose that you did not add the binary output files? We could also choose to include low resolution gnuplot files to the test data. What do you think?

@gassmoeller

This comment has been minimized.

Copy link
Contributor

commented Mar 18, 2019

Anyway this is better than before, so I am going to merge. Thanks!

@gassmoeller gassmoeller merged commit 10511c8 into geodynamics:master Mar 18, 2019

2 checks passed

continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins.tjhei.info/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.