Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove constraint consistency check #3282

Merged
merged 1 commit into from Nov 6, 2019

Conversation

@tjhei
Copy link
Member

tjhei commented Nov 4, 2019

It turns out that constraints.is_consistent_in_parallel() is too eager
and gives false alarm if constraints differ by machine epsilon. For now,
just remove this call.

@tjhei

This comment has been minimized.

Copy link
Member Author

tjhei commented Nov 4, 2019

see #3248

Copy link
Contributor

gassmoeller left a comment

Can you leave a TODO with the number of this PR to remind us to put it in again once the function works? After that feel free to merge.

@bangerth

This comment has been minimized.

Copy link
Contributor

bangerth commented Nov 5, 2019

This is an acceptable stop-gap, but I'd still like to find out more about why you get different constraints. I think we ought to be computing them in the exact same way on all processors.

@tjhei tjhei force-pushed the tjhei:constraints_consistent_fix branch from 75e0226 to 99ef341 Nov 5, 2019
It turns out that constraints.is_consistent_in_parallel() is too eager
and gives false alarm if constraints differ by machine epsilon. For now,
just remove this call.

see #3248.
@tjhei tjhei force-pushed the tjhei:constraints_consistent_fix branch from 99ef341 to ef12842 Nov 5, 2019
@tjhei

This comment has been minimized.

Copy link
Member Author

tjhei commented Nov 5, 2019

updated.

@gassmoeller gassmoeller merged commit 2e05afb into geodynamics:master Nov 6, 2019
2 checks passed
2 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
jenkins.tjhei.info/pr-head This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.