Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Move ownership and responiblity of particle world to simulator #3294
Currently the particle world is owned by the particle post-processor. This may have made sense in the beginning, but since particles can be active now it seems to make more sense to me for them to be part of the simulator. Furthermore, I am developing a plugin which needs access to up to date particle information. Currently this is only the case if the user provides that post processor after the particle post processor because the particle post-processor also moves and updates the particles.
Although further reorganization might we wanted in the future, this pull request is limited to just letting the simulator own the particle world and update the particles, so that the order given by the user of the post-processors do not matter any more.
I am still looking at a bug (there seems to be a subscriptor which is not deleted at the end of the simulation) and some of the code can probably be improved, but I thought it might be good to make this pull request now so that changes can be discussed early on.
And thanks @gassmoeller for the help and advice already giving :)
For all pull requests:
For new features/models or changes of existing features: