Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in AsciiDataLookup::load_file for time dependent non-equidistant data files #3302

Merged

Conversation

@gassmoeller
Copy link
Contributor

gassmoeller commented Nov 27, 2019

As described in the changelog entry. We did not correctly clear the coordinate_values vector before reading a new file. This caused the InterpolatedTensorProductGridData class to throw an exception because the coordinates were not strictly ascending (because of the jump between old and new coordinates). The test I added crashed before and now works as expected.
This bug was found by @sibiaoliu.

@tjhei
tjhei approved these changes Dec 2, 2019
@tjhei tjhei merged commit 880ada4 into geodynamics:master Dec 2, 2019
3 checks passed
3 checks passed
continuous-integration/jenkins/pr-merge This commit looks good
Details
coverage/coveralls First build on PR-3302 at 90.1%
Details
jenkins.tjhei.info/pr-head This commit looks good
Details
@gassmoeller gassmoeller deleted the gassmoeller:fix_time_dependent_ascii_lookup branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.